EdDSA support #256
Merged
EdDSA support #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a93e3eb to
7b465fd
Compare
e44c4e5 to
eeab2c6
Compare
This was referenced Jul 26, 2021
c653b82 to
9e6ce5f
Compare
eb01fd0 to
b73a4ce
Compare
ep69
approved these changes
Apr 22, 2022
| def do_eddsa_test_from_openssl(self, curve): | ||
| curvename = curve.name | ||
|
|
||
| if os.path.isdir("t"): |
There was a problem hiding this comment.
What about if there is a file called t? Do we care about such situations?
There was a problem hiding this comment.
yes, it's a problem, but it's been like that for the past 10 years for this library (there are other, non EdDSA tests that use the t directory too), so I don't think it's a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for EdDSA signatures (Ed25519 and Ed448).
Todo: