Skip to content

No cabal-doctest in Setup.hs #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

No cabal-doctest in Setup.hs #335

merged 1 commit into from
Jun 30, 2021

Conversation

facundominguez
Copy link
Member

This allows projects to depend on linear-types without depending on cabal-doctest

@facundominguez facundominguez requested a review from utdemir June 28, 2021 21:20
@facundominguez
Copy link
Member Author

I'm submitting this in case you want to get rid of cabal-doctest. Otherwise, feel free to close this PR.

utdemir
utdemir approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@utdemir utdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the previous Setup.hs was a mistake, we were supposed to have our doctests disabled and there's no reason to try to pull it here.

@facundominguez facundominguez added the merge-queue merge on green CI label Jun 28, 2021
@facundominguez
Copy link
Member Author

How do we get the CI checks unstuck here?

@utdemir utdemir force-pushed the fd/no-cabal-doctest branch from ec0b5aa to 086278f Compare June 29, 2021 23:50
@utdemir utdemir merged commit 0e2824a into master Jun 30, 2021
@utdemir utdemir deleted the fd/no-cabal-doctest branch June 30, 2021 00:09
@utdemir
Copy link
Contributor

utdemir commented Jun 30, 2021

How do we get the CI checks unstuck here?

CI setup has changed recently (#332), so I just had to rebase this branch on top of a newer master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@utdemir utdemir utdemir approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@utdemir utdemir

Labels
merge-queue merge on green CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facundominguez @utdemir