-
Notifications
You must be signed in to change notification settings - Fork 40
Some documentation on genericTraverse and friends #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm the one who wrote that, but I'd point to @ekmett. The |
Right, I don't think I understand this enough to document it. I played around enough with the types at some point to get what was going on, but that has long since been garbage collected from my brain. |
Indeed, I now realise that #316 was coauthored 🙂 (I'd like to bring it up to master, now, but it's a non-trivial amount of work to merge master in it. I don't really have time to do so, would you?). Regarding this PR: I don't necessarily ask for a detailed explanation (though it would be welcome), but enough to get an intuition of why these types specifically? |
I will work on bringing that branch (or its main ideas) up to |
I wrote a little documentation for |
-- | ||
-- Note that, contrary to many other classes in linear-base, we can't define | ||
-- `Traversable T` using deriving via, because the | ||
-- [role](https://downloads.haskell.org/ghc/latest/docs/html/users_guide/exts/roles.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link for role
may be hard to hit on mobile browsers and other touchscreens, since it's so short. How much does that matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it matters a little, but not a ton (you can always zoom on mobile). So if you have a good solution, I'll take it. But let's not spend a lot of time on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just fix these two typos.
a85e826
to
c77dbfe
Compare
Just small docstring fixes.
@sjoerdvisscher, you pioneered the use of
Yoneda
andCurried
forfusion. Could you write the missing bit of documentation?