Skip to content

chore: use rollup types exposed from Vite #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

sapphi-red
Copy link
Member

Description

Use rollup types exposed from Vite. This will make ecosystem-ci w/ rolldown-vite run without type errors (one test fail due to lib mode not supported).

The rollup types were exposed since Vite 4.2.0 (vitejs/vite@6e49e52). This is fine because plugin-vue only supports Vite 5+.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented May 1, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@583
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@583

commit: 9c5e74f

@sapphi-red
Copy link
Member Author

Merging as this is probably uncontroversial.

@sapphi-red sapphi-red merged commit 2e1287f into main May 1, 2025
11 checks passed
@sapphi-red sapphi-red deleted the chore/use-type-from-vite branch May 1, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant