-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Upgrade Nightwatch to v1.2 and update bundled config and generated tests #4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Nightwatch to v1.2 and update bundled config and generated tests #4541
Conversation
… added new cli flags: --headless, --parallel...; added support for running chromedriver and geckodriver standalone; added unit tests
Is it possible to upgrade Chrome in AppVeyour? |
I've added a |
The rest of this PR looks pretty cool to me. I'll merge it after the dependency issues get fixed. |
Great, so to summarise, changes required:
Anything else I might have missed?
My pleasure. Feel free to reach out regarding Nightwatch related bugs and/or enhancements, we'd be happy to assist. |
Yeah, I think that's all. |
Tests are failing. |
packages/@vue/cli-plugin-e2e-nightwatch/generator/template/tests/e2e/specs/test.js
Outdated
Show resolved
Hide resolved
expect(testSettings.parallel_mode).toStrictEqual(true) | ||
expect(testSettings.test_workers).toStrictEqual(true) | ||
|
||
expect(Object.keys(results.modules)).toEqual([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the tests are run in parallel, the order of results.modules
is nondeterministic, which could cause test failures.
expect(Object.keys(results.modules)).toEqual([ | |
expect(Object.keys(results.modules.sort())).toEqual([ |
Hey @beatfactor, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Overview
This PR upgrades the Nightwatch version bundled with the
cli-e2e-nightwatch
plugin to latest v1.2 version. In addition, it adds several new features for running end-to-end tests with Nightwatch in a Vue application a bit more pleasant of an experience.Improvements
--headless
) with Chrome and FirefoxNew CLI flags
--use-selenium
: allows using the Selenium standalone server instead of running Webdriver standalone--parallel
: enable parallel mode via test workers (only available when using chromedriver)--headless
: run tests with the browser (chrome/firefox) in headless modeOther