add new property Location.AltitudeReferenceSystem

[janusw]

Description of Change

In order to deal with platform differences of Location.Altitude, this PR adds a new property Location.AltitudeReferenceSystem and a corresponding enum, which is a copy of Windows.Devices.Geolocation.AltitudeReferenceSystem.

Bugs Fixed

• Related to issue Location.Altitude not consistent between Android and iOS #1177

API Changes

Added:

• enum AltitudeReferenceSystem
• AltitudeReferenceSystem Location.AltitudeReferenceSystem { get; set; }

Changed:

• None.

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of master at time of PR
• Changes adhere to coding standard
• Updated documentation (see walkthrough)

[jamesmontemagno]

Instead of a hard case I would maybe to a little method that does a switch expression over it. Besides that it looks good.

[janusw]

Instead of a hard case I would maybe to a little method that does a switch expression over it.

Well, in the current state that is certainly not necessary. What you worry about is probably that Windows.Devices.Geolocation.AltitudeReferenceSystem might get extended with additional values in the future? For that case it might be simpler to check with Enum.IsDefined?

[janusw]

Instead of a hard case I would maybe to a little method that does a switch expression over it.

Well, in the current state that is certainly not necessary. What you worry about is probably that Windows.Devices.Geolocation.AltitudeReferenceSystem might get extended with additional values in the future? For that case it might be simpler to check with Enum.IsDefined?

I implemented that in c4c4e90. What do you think about it, @jamesmontemagno?

[jamesmontemagno]

Did a little modification on what I was talking about. Should be good now.

[janusw]

Did a little modification on what I was talking about. Should be good now.

Agree, looks good. Thank you!

[janusw]

Ping! @jamesmontemagno, can this be merged?