Fixed lack of oidc discovery filtering during testing

[bookstack] / app / Http / Controllers / Auth / OidcController.php

<?php

namespace BookStack\Http\Controllers\Auth;

use BookStack\Auth\Access\Oidc\OidcService;
use BookStack\Http\Controllers\Controller;
use Illuminate\Http\Request;

class OidcController extends Controller
{

    protected $oidcService;

    /**
     * OpenIdController constructor.
     */
    public function __construct(OidcService $oidcService)
    {
        $this->oidcService = $oidcService;
        $this->middleware('guard:oidc');
    }

    /**
     * Start the authorization login flow via OIDC.
     */
    public function login()
    {
        $loginDetails = $this->oidcService->login();
        session()->flash('oidc_state', $loginDetails['state']);

        return redirect($loginDetails['url']);
    }

    /**
     * Authorization flow redirect callback.
     * Processes authorization response from the OIDC Authorization Server.
     */
    public function callback(Request $request)
    {
        $storedState = session()->pull('oidc_state');
        $responseState = $request->query('state');

        if ($storedState !== $responseState) {
            $this->showErrorNotification(trans('errors.oidc_fail_authed', ['system' => config('oidc.name')]));
            return redirect('/login');
        }

        $this->oidcService->processAuthorizeResponse($request->query('code'));
        return redirect()->intended();
    }
}