Covered app icon setting with testing

[bookstack] / app / Http / Controllers / SettingController.php

diff --git a/app/Http/Controllers/SettingController.php b/app/Http/Controllers/SettingController.php
index d9d66042e19ba0bc998d0b74e14b0855b14ff4be..1e13d7cb77ed4001598f2cb8a85bbde357e7ea6c 100644 (file)
--- a/app/Http/Controllers/SettingController.php
+++ b/app/Http/Controllers/SettingController.php
@@ -1,91 +1,69 @@
-<?php namespace BookStack\Http\Controllers;
+<?php
 
-use BookStack\Services\ImageService;
+namespace BookStack\Http\Controllers;
+
+use BookStack\Actions\ActivityType;
+use BookStack\Auth\User;
+use BookStack\Settings\AppSettingsStore;
+use BookStack\Uploads\ImageRepo;
 use Illuminate\Http\Request;
-use Illuminate\Http\Response;
-use Setting;
 
 class SettingController extends Controller
 {
-    /**
-     * Display a listing of the settings.
-     * @return Response
-     */
-    public function index()
-    {
-        $this->checkPermission('settings-manage');
-        $this->setPageTitle(trans('settings.settings'));
-
-        // Get application version
-        $version = trim(file_get_contents(base_path('version')));
-
-        return view('settings/index', ['version' => $version]);
-    }
+    protected array $settingCategories = ['features', 'customization', 'registration'];
 
     /**
-     * Update the specified settings in storage.
-     * @param  Request $request
-     * @return Response
+     * Handle requests to the settings index path.
      */
-    public function update(Request $request)
+    public function index()
     {
-        $this->preventAccessForDemoUsers();
-        $this->checkPermission('settings-manage');
-
-        // Cycles through posted settings and update them
-        foreach ($request->all() as $name => $value) {
-            if (strpos($name, 'setting-') !== 0) {
-                continue;
-            }
-            $key = str_replace('setting-', '', trim($name));
-            Setting::put($key, $value);
-        }
-
-        session()->flash('success', trans('settings.settings_save_success'));
-        return redirect('/settings');
+        return redirect('/settings/features');
     }
 
     /**
-     * Show the page for application maintenance.
-     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+     * Display the settings for the given category.
      */
-    public function showMaintenance()
+    public function category(string $category)
     {
+        $this->ensureCategoryExists($category);
         $this->checkPermission('settings-manage');
-        $this->setPageTitle(trans('settings.maint'));
+        $this->setPageTitle(trans('settings.settings'));
 
         // Get application version
         $version = trim(file_get_contents(base_path('version')));
 
-        return view('settings/maintenance', ['version' => $version]);
+        return view('settings.' . $category, [
+            'category'  => $category,
+            'version'   => $version,
+            'guestUser' => User::getDefault(),
+        ]);
     }
 
     /**
-     * Action to clean-up images in the system.
-     * @param Request $request
-     * @param ImageService $imageService
-     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
+     * Update the specified settings in storage.
      */
-    public function cleanupImages(Request $request, ImageService $imageService)
+    public function update(Request $request, AppSettingsStore $store, string $category)
     {
+        $this->ensureCategoryExists($category);
+        $this->preventAccessInDemoMode();
         $this->checkPermission('settings-manage');
+        $this->validate($request, [
+            'app_logo' => ['nullable', ...$this->getImageValidationRules()],
+            'app_icon' => ['nullable', ...$this->getImageValidationRules()],
+        ]);
 
-        $checkRevisions = !($request->get('ignore_revisions', 'false') === 'true');
-        $dryRun = !($request->has('confirm'));
+        $store->storeFromUpdateRequest($request, $category);
 
-        $imagesToDelete = $imageService->deleteUnusedImages($checkRevisions, $dryRun);
-        $deleteCount = count($imagesToDelete);
-        if ($deleteCount === 0) {
-            session()->flash('warning', trans('settings.maint_image_cleanup_nothing_found'));
-            return redirect('/settings/maintenance')->withInput();
-        }
+        $this->logActivity(ActivityType::SETTINGS_UPDATE, $category);
+        $this->showSuccessNotification(trans('settings.settings_save_success'));
 
-        if ($dryRun) {
-            session()->flash('cleanup-images-warning', trans('settings.maint_image_cleanup_warning', ['count' => $deleteCount]));
-        } else {
-            session()->flash('success', trans('settings.maint_image_cleanup_success', ['count' => $deleteCount]));
-        }
+        return redirect("/settings/{$category}");
+    }
 
-        return redirect('/settings/maintenance#image-cleanup')->withInput();
+    protected function ensureCategoryExists(string $category): void
+    {
+        if (!in_array($category, $this->settingCategories)) {
+            abort(404);
+        }
     }
 }