Added safe mime sniffing to prevent serving HTML

[bookstack] / tests / Uploads / AttachmentTest.php
diff --git a/tests/Uploads/AttachmentTest.php b/tests/Uploads/AttachmentTest.php

index 60fd370b676d0d592be5bfad9610ff04c0e55dcf..26f092bcc3b5c0039f823ff0d43c4457e0c8de3d 100644 (file)
--- a/tests/Uploads/AttachmentTest.php
+++ b/tests/Uploads/AttachmentTest.php
@@ -9,6 +9,7 @@ use BookStack\Uploads\Attachment;
  use BookStack\Uploads\AttachmentService;
  use Illuminate\Http\UploadedFile;
  use Tests\TestCase;
+use Tests\TestResponse;
  
  class AttachmentTest extends TestCase
  {
@@ -44,6 +45,20 @@ class AttachmentTest extends TestCase
          return Attachment::query()->latest()->first();
      }
  
+    /**
+     * Create a new upload attachment from the given data.
+     */
+    protected function createUploadAttachment(Page $page, string $filename, string $content, string $mimeType): Attachment
+    {
+        $file = tmpfile();
+        $filePath = stream_get_meta_data($file)['uri'];
+        file_put_contents($filePath, $content);
+        $upload = new UploadedFile($filePath, $filename, $mimeType, null, true);
+
+        $this->call('POST', '/attachments/upload', ['uploaded_to' => $page->id], [], ['file' => $upload], []);
+        return $page->attachments()->latest()->firstOrFail();
+    }
+
      /**
       * Delete all uploaded files.
       * To assist with cleanup.
@@ -305,7 +320,24 @@ class AttachmentTest extends TestCase
          // http-foundation/Response does some 'fixing' of responses to add charsets to text responses.
          $attachmentGet->assertHeader('Content-Type', 'text/plain; charset=UTF-8');
          $attachmentGet->assertHeader('Content-Disposition', 'inline; filename="upload_test_file.txt"');
+        $attachmentGet->assertHeader('X-Content-Type-Options', 'nosniff');
  
          $this->deleteUploads();
      }
+
+    public function test_html_file_access_with_open_forces_plain_content_type()
+    {
+        $page = Page::query()->first();
+        $this->asAdmin();
+
+        $attachment = $this->createUploadAttachment($page, 'test_file.html', '<html></html><p>testing</p>', 'text/html');
+
+        $attachmentGet = $this->get($attachment->getUrl(true));
+        // http-foundation/Response does some 'fixing' of responses to add charsets to text responses.
+        $attachmentGet->assertHeader('Content-Type', 'text/plain; charset=UTF-8');
+        $attachmentGet->assertHeader('Content-Disposition', 'inline; filename="test_file.html"');
+
+        $this->deleteUploads();
+    }
+
  }