namespace Tests\Entity;
-use BookStack\Actions\Tag;
+use BookStack\Activity\Models\Tag;
use BookStack\Entities\Models\Book;
use BookStack\Entities\Models\Bookshelf;
+use BookStack\Entities\Models\Chapter;
use Tests\TestCase;
class EntitySearchTest extends TestCase
$exactSearchB->assertStatus(200)->assertDontSee($page->name);
}
+ public function test_negated_searches()
+ {
+ $page = $this->entities->newPage(['name' => 'My new test negation page', 'html' => '<p>An angry tortoise wore trumpeted plimsoles</p>']);
+ $page->tags()->saveMany([new Tag(['name' => 'DonkCount', 'value' => '500'])]);
+ $page->created_by = $this->users->admin()->id;
+ $page->save();
+
+ $editor = $this->users->editor();
+ $this->actingAs($editor);
+
+ $exactSearch = $this->get('/search?term=' . urlencode('negation -"tortoise"'));
+ $exactSearch->assertStatus(200)->assertDontSeeText($page->name);
+
+ $tagSearchA = $this->get('/search?term=' . urlencode('negation [DonkCount=500]'));
+ $tagSearchA->assertStatus(200)->assertSeeText($page->name);
+ $tagSearchB = $this->get('/search?term=' . urlencode('negation -[DonkCount=500]'));
+ $tagSearchB->assertStatus(200)->assertDontSeeText($page->name);
+
+ $filterSearchA = $this->get('/search?term=' . urlencode('negation -{created_by:me}'));
+ $filterSearchA->assertStatus(200)->assertSeeText($page->name);
+ $page->created_by = $editor->id;
+ $page->save();
+ $filterSearchB = $this->get('/search?term=' . urlencode('negation -{created_by:me}'));
+ $filterSearchB->assertStatus(200)->assertDontSeeText($page->name);
+ }
+
public function test_search_terms_with_delimiters_are_converted_to_exact_matches()
{
$this->asEditor();
public function test_search_filters()
{
$page = $this->entities->newPage(['name' => 'My new test quaffleachits', 'html' => 'this is about an orange donkey danzorbhsing']);
- $editor = $this->getEditor();
+ $editor = $this->users->editor();
$this->actingAs($editor);
// Viewed filter searches
// Restricted filter
$this->get('/search?term=' . urlencode('danzorbhsing {is_restricted}'))->assertDontSee($page->name);
- $this->entities->setPermissions($page, ['view'], [$editor->roles->first()]);
+ $this->permissions->setEntityPermissions($page, ['view'], [$editor->roles->first()]);
$this->get('/search?term=' . urlencode('danzorbhsing {is_restricted}'))->assertSee($page->name);
// Date filters
$chapterSearch->assertSee($chapter->book->getShortName(42));
}
+ public function test_entity_selector_shows_breadcrumbs_on_default_view()
+ {
+ $page = $this->entities->pageWithinChapter();
+ $this->asEditor()->get($page->chapter->getUrl());
+
+ $resp = $this->asEditor()->get('/search/entity-selector?types=book,chapter&permission=page-create');
+ $html = $this->withHtml($resp);
+ $html->assertElementContains('.chapter.entity-list-item', $page->chapter->name);
+ $html->assertElementContains('.chapter.entity-list-item .entity-item-snippet', $page->book->getShortName(42));
+ }
+
public function test_entity_selector_search_reflects_items_without_permission()
{
$page = $this->entities->page();
$this->withHtml($resp)->assertElementContains($baseSelector, $page->name);
$this->withHtml($resp)->assertElementNotContains($baseSelector, "You don't have the required permissions to select this item");
- $resp = $this->actingAs($this->getViewer())->get($searchUrl);
+ $resp = $this->actingAs($this->users->viewer())->get($searchUrl);
$this->withHtml($resp)->assertElementContains($baseSelector, $page->name);
$this->withHtml($resp)->assertElementContains($baseSelector, "You don't have the required permissions to select this item");
}
+ public function test_entity_template_selector_search()
+ {
+ $templatePage = $this->entities->newPage(['name' => 'Template search test', 'html' => 'template test']);
+ $templatePage->template = true;
+ $templatePage->save();
+
+ $nonTemplatePage = $this->entities->newPage(['name' => 'Nontemplate page', 'html' => 'nontemplate', 'template' => false]);
+
+ // Visit both to make popular
+ $this->asEditor()->get($templatePage->getUrl());
+ $this->get($nonTemplatePage->getUrl());
+
+ $normalSearch = $this->get('/search/entity-selector-templates?term=test');
+ $normalSearch->assertSee($templatePage->name);
+ $normalSearch->assertDontSee($nonTemplatePage->name);
+
+ $normalSearch = $this->get('/search/entity-selector-templates?term=beans');
+ $normalSearch->assertDontSee($templatePage->name);
+ $normalSearch->assertDontSee($nonTemplatePage->name);
+
+ $defaultListTest = $this->get('/search/entity-selector-templates');
+ $defaultListTest->assertSee($templatePage->name);
+ $defaultListTest->assertDontSee($nonTemplatePage->name);
+
+ $this->permissions->disableEntityInheritedPermissions($templatePage);
+
+ $normalSearch = $this->get('/search/entity-selector-templates?term=test');
+ $normalSearch->assertDontSee($templatePage->name);
+
+ $defaultListTest = $this->get('/search/entity-selector-templates');
+ $defaultListTest->assertDontSee($templatePage->name);
+ }
+
public function test_sibling_search_for_pages()
{
$chapter = $this->entities->chapterHasPages();
$this->assertGreaterThan(2, count($chapter->pages), 'Ensure we\'re testing with at least 1 sibling');
$page = $chapter->pages->first();
- $search = $this->actingAs($this->getViewer())->get("/search/entity/siblings?entity_id={$page->id}&entity_type=page");
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$page->id}&entity_type=page");
$search->assertSuccessful();
foreach ($chapter->pages as $page) {
$search->assertSee($page->name);
public function test_sibling_search_for_pages_without_chapter()
{
$page = $this->entities->pageNotWithinChapter();
- $bookChildren = $page->book->getDirectChildren();
+ $bookChildren = $page->book->getDirectVisibleChildren();
$this->assertGreaterThan(2, count($bookChildren), 'Ensure we\'re testing with at least 1 sibling');
- $search = $this->actingAs($this->getViewer())->get("/search/entity/siblings?entity_id={$page->id}&entity_type=page");
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$page->id}&entity_type=page");
$search->assertSuccessful();
foreach ($bookChildren as $child) {
$search->assertSee($child->name);
public function test_sibling_search_for_chapters()
{
$chapter = $this->entities->chapter();
- $bookChildren = $chapter->book->getDirectChildren();
+ $bookChildren = $chapter->book->getDirectVisibleChildren();
$this->assertGreaterThan(2, count($bookChildren), 'Ensure we\'re testing with at least 1 sibling');
- $search = $this->actingAs($this->getViewer())->get("/search/entity/siblings?entity_id={$chapter->id}&entity_type=chapter");
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$chapter->id}&entity_type=chapter");
$search->assertSuccessful();
foreach ($bookChildren as $child) {
$search->assertSee($child->name);
$book = $books->first();
$this->assertGreaterThan(2, count($books), 'Ensure we\'re testing with at least 1 sibling');
- $search = $this->actingAs($this->getViewer())->get("/search/entity/siblings?entity_id={$book->id}&entity_type=book");
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$book->id}&entity_type=book");
$search->assertSuccessful();
foreach ($books as $expectedBook) {
$search->assertSee($expectedBook->name);
$shelf = $shelves->first();
$this->assertGreaterThan(2, count($shelves), 'Ensure we\'re testing with at least 1 sibling');
- $search = $this->actingAs($this->getViewer())->get("/search/entity/siblings?entity_id={$shelf->id}&entity_type=bookshelf");
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$shelf->id}&entity_type=bookshelf");
$search->assertSuccessful();
foreach ($shelves as $expectedShelf) {
$search->assertSee($expectedShelf->name);
}
}
+ public function test_sibling_search_for_books_provides_results_in_alphabetical_order()
+ {
+ $contextBook = $this->entities->book();
+ $searchBook = $this->entities->book();
+
+ $searchBook->name = 'Zebras';
+ $searchBook->save();
+
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$contextBook->id}&entity_type=book");
+ $this->withHtml($search)->assertElementNotContains('a:first-child', 'Zebras');
+
+ $searchBook->name = 'AAAAAAArdvarks';
+ $searchBook->save();
+
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$contextBook->id}&entity_type=book");
+ $this->withHtml($search)->assertElementContains('a:first-child', 'AAAAAAArdvarks');
+ }
+
+ public function test_sibling_search_for_shelves_provides_results_in_alphabetical_order()
+ {
+ $contextShelf = $this->entities->shelf();
+ $searchShelf = $this->entities->shelf();
+
+ $searchShelf->name = 'Zebras';
+ $searchShelf->save();
+
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$contextShelf->id}&entity_type=bookshelf");
+ $this->withHtml($search)->assertElementNotContains('a:first-child', 'Zebras');
+
+ $searchShelf->name = 'AAAAAAArdvarks';
+ $searchShelf->save();
+
+ $search = $this->actingAs($this->users->viewer())->get("/search/entity/siblings?entity_id={$contextShelf->id}&entity_type=bookshelf");
+ $this->withHtml($search)->assertElementContains('a:first-child', 'AAAAAAArdvarks');
+ }
+
public function test_search_works_on_updated_page_content()
{
$page = $this->entities->page();
$search->assertSee($page->getUrl(), false);
}
- public function test_searches_with_user_filters_adds_them_into_advanced_search_form()
+ public function test_backslashes_can_be_searched_upon()
+ {
+ $page = $this->entities->newPage(['name' => 'TermA', 'html' => '
+ <p>More info is at the path \\\\cat\\dog\\badger</p>
+ ']);
+ $page->tags()->save(new Tag(['name' => '\\Category', 'value' => '\\animals\\fluffy']));
+
+ $search = $this->asEditor()->get('/search?term=' . urlencode('\\\\cat\\dog'));
+ $search->assertSee($page->getUrl(), false);
+
+ $search = $this->asEditor()->get('/search?term=' . urlencode('"\\dog\\\\"'));
+ $search->assertSee($page->getUrl(), false);
+
+ $search = $this->asEditor()->get('/search?term=' . urlencode('"\\badger\\\\"'));
+ $search->assertDontSee($page->getUrl(), false);
+
+ $search = $this->asEditor()->get('/search?term=' . urlencode('[\\Categorylike%\\fluffy]'));
+ $search->assertSee($page->getUrl(), false);
+ }
+
+ public function test_searches_with_terms_without_controls_includes_them_in_extras()
+ {
+ $resp = $this->asEditor()->get('/search?term=' . urlencode('test {updated_by:dan} {created_by:dan} -{viewed_by_me} -[a=b] -"dog" {is_template} {sort_by:last_commented}'));
+ $this->withHtml($resp)->assertFieldHasValue('extras', '{updated_by:dan} {created_by:dan} {is_template} {sort_by:last_commented} -"dog" -[a=b] -{viewed_by_me}');
+ }
+
+ public function test_negated_searches_dont_show_in_inputs()
{
- $resp = $this->asEditor()->get('/search?term=' . urlencode('test {updated_by:dan} {created_by:dan}'));
- $this->withHtml($resp)->assertElementExists('form input[name="filters[updated_by]"][value="dan"]');
- $this->withHtml($resp)->assertElementExists('form input[name="filters[created_by]"][value="dan"]');
+ $resp = $this->asEditor()->get('/search?term=' . urlencode('-{created_by:me} -[a=b] -"dog"'));
+ $this->withHtml($resp)->assertElementNotExists('input[name="tags[]"][value="a=b"]');
+ $this->withHtml($resp)->assertElementNotExists('input[name="exact[]"][value="dog"]');
+ $this->withHtml($resp)->assertElementNotExists('input[name="filters[created_by]"][value="me"][checked="checked"]');
}
public function test_searches_with_user_filters_using_me_adds_them_into_advanced_search_form()
projects / bookstack / blobdiff