Fixed unselectable checkbox role form options

[bookstack] / app / Http / Controllers / RoleController.php

diff --git a/app/Http/Controllers/RoleController.php b/app/Http/Controllers/RoleController.php
index 2bf0a7b19b9afeaa803c698753d844cdeded0acb..135ba329f61cfeb6ea0fd11705a5d1be90ddde82 100644 (file)
--- a/app/Http/Controllers/RoleController.php
+++ b/app/Http/Controllers/RoleController.php
@@ -116,14 +116,8 @@ class RoleController extends Controller
             'mfa_enforced' => ['string'],
         ]);
 
-        if (isset($data['permissions'])) {
-            $data['permissions'] = array_keys($data['permissions']);
-        }
-
-        if (isset($data['mfa_enforced'])) {
-            $data['mfa_enforced'] = $data['mfa_enforced'] === 'true';
-        }
-
+        $data['permissions'] = array_keys($data['permissions'] ?? []);
+        $data['mfa_enforced'] = ($data['mfa_enforced'] ?? 'false') === 'true';
         $this->permissionsRepo->updateRole($id, $data);
 
         return redirect('/settings/roles');