-<?php namespace Tests;
+<?php
-use BookStack\Page;
-use BookStack\Comment;
+namespace Tests\Entity;
-class CommentTest extends BrowserKitTest
-{
+use BookStack\Activity\ActivityType;
+use BookStack\Activity\Models\Comment;
+use BookStack\Entities\Models\Page;
+use Tests\TestCase;
+class CommentTest extends TestCase
+{
public function test_add_comment()
{
$this->asAdmin();
- $page = $this->getPage();
+ $page = $this->entities->page();
- $this->addComment($page);
- }
+ $comment = Comment::factory()->make(['parent_id' => 2]);
+ $resp = $this->postJson("/comment/$page->id", $comment->getAttributes());
- public function test_comment_reply()
- {
- $this->asAdmin();
- $page = $this->getPage();
+ $resp->assertStatus(200);
+ $resp->assertSee($comment->text);
+
+ $pageResp = $this->get($page->getUrl());
+ $pageResp->assertSee($comment->text);
- // add a normal comment
- $createdComment = $this->addComment($page);
+ $this->assertDatabaseHas('comments', [
+ 'local_id' => 1,
+ 'entity_id' => $page->id,
+ 'entity_type' => Page::newModelInstance()->getMorphClass(),
+ 'text' => null,
+ 'parent_id' => 2,
+ ]);
- // reply to the added comment
- $this->addComment($page, $createdComment['id']);
+ $this->assertActivityExists(ActivityType::COMMENT_CREATE);
}
public function test_comment_edit()
{
$this->asAdmin();
- $page = $this->getPage();
-
- $createdComment = $this->addComment($page);
- $comment = [
- 'id' => $createdComment['id'],
- 'page_id' => $createdComment['page_id']
- ];
- $this->updateComment($comment);
+ $page = $this->entities->page();
+
+ $comment = Comment::factory()->make();
+ $this->postJson("/comment/$page->id", $comment->getAttributes());
+
+ $comment = $page->comments()->first();
+ $newHtml = '<p>updated text content</p>';
+ $resp = $this->putJson("/comment/$comment->id", [
+ 'html' => $newHtml,
+ ]);
+
+ $resp->assertStatus(200);
+ $resp->assertSee($newHtml, false);
+ $resp->assertDontSee($comment->html, false);
+
+ $this->assertDatabaseHas('comments', [
+ 'html' => $newHtml,
+ 'entity_id' => $page->id,
+ ]);
+
+ $this->assertActivityExists(ActivityType::COMMENT_UPDATE);
}
public function test_comment_delete()
{
$this->asAdmin();
- $page = $this->getPage();
+ $page = $this->entities->page();
- $createdComment = $this->addComment($page);
+ $comment = Comment::factory()->make();
+ $this->postJson("/comment/$page->id", $comment->getAttributes());
- $this->deleteComment($createdComment['id']);
- }
+ $comment = $page->comments()->first();
- private function getPage() {
- $page = Page::first();
- return $page;
+ $resp = $this->delete("/comment/$comment->id");
+ $resp->assertStatus(200);
+
+ $this->assertDatabaseMissing('comments', [
+ 'id' => $comment->id,
+ ]);
+
+ $this->assertActivityExists(ActivityType::COMMENT_DELETE);
}
+ public function test_scripts_cannot_be_injected_via_comment_html()
+ {
+ $page = $this->entities->page();
+
+ $script = '<script>const a = "script";</script><p onclick="1">My lovely comment</p>';
+ $this->asAdmin()->postJson("/comment/$page->id", [
+ 'html' => $script,
+ ]);
+
+ $pageView = $this->get($page->getUrl());
+ $pageView->assertDontSee($script, false);
+ $pageView->assertSee('<p>My lovely comment</p>', false);
+
+ $comment = $page->comments()->first();
+ $this->putJson("/comment/$comment->id", [
+ 'html' => $script . '<p>updated</p>',
+ ]);
+
+ $pageView = $this->get($page->getUrl());
+ $pageView->assertDontSee($script, false);
+ $pageView->assertSee('<p>My lovely comment</p><p>updated</p>');
+ }
- private function addComment($page, $parentCommentId = null) {
- $comment = factory(Comment::class)->make();
- $url = "/ajax/page/$page->id/comment/";
- $request = [
- 'text' => $comment->text,
- 'html' => $comment->html
- ];
- if (!empty($parentCommentId)) {
- $request['parent_id'] = $parentCommentId;
- }
- $this->call('POST', $url, $request);
-
- $createdComment = $this->checkResponse();
- return $createdComment;
+ public function test_scripts_are_removed_even_if_already_in_db()
+ {
+ $page = $this->entities->page();
+ Comment::factory()->create([
+ 'html' => '<script>superbadscript</script><p onclick="superbadonclick">scriptincommentest</p>',
+ 'entity_type' => 'page', 'entity_id' => $page
+ ]);
+
+ $resp = $this->asAdmin()->get($page->getUrl());
+ $resp->assertSee('scriptincommentest', false);
+ $resp->assertDontSee('superbadscript', false);
+ $resp->assertDontSee('superbadonclick', false);
}
- private function updateComment($comment) {
- $tmpComment = factory(Comment::class)->make();
- $url = '/ajax/page/' . $comment['page_id'] . '/comment/ ' . $comment['id'];
- $request = [
- 'text' => $tmpComment->text,
- 'html' => $tmpComment->html
- ];
+ public function test_reply_comments_are_nested()
+ {
+ $this->asAdmin();
+ $page = $this->entities->page();
- $this->call('PUT', $url, $request);
+ $this->postJson("/comment/$page->id", ['html' => '<p>My new comment</p>']);
+ $this->postJson("/comment/$page->id", ['html' => '<p>My new comment</p>']);
- $updatedComment = $this->checkResponse();
- return $updatedComment;
+ $respHtml = $this->withHtml($this->get($page->getUrl()));
+ $respHtml->assertElementCount('.comment-branch', 3);
+ $respHtml->assertElementNotExists('.comment-branch .comment-branch');
+
+ $comment = $page->comments()->first();
+ $resp = $this->postJson("/comment/$page->id", [
+ 'html' => '<p>My nested comment</p>', 'parent_id' => $comment->local_id
+ ]);
+ $resp->assertStatus(200);
+
+ $respHtml = $this->withHtml($this->get($page->getUrl()));
+ $respHtml->assertElementCount('.comment-branch', 4);
+ $respHtml->assertElementContains('.comment-branch .comment-branch', 'My nested comment');
}
- private function deleteComment($commentId) {
- // Route::delete('/ajax/comment/{id}', 'CommentController@destroy');
- $url = '/ajax/comment/' . $commentId;
- $this->call('DELETE', $url);
+ public function test_comments_are_visible_in_the_page_editor()
+ {
+ $page = $this->entities->page();
+
+ $this->asAdmin()->postJson("/comment/$page->id", ['html' => '<p>My great comment to see in the editor</p>']);
- $deletedComment = $this->checkResponse();
- return $deletedComment;
+ $respHtml = $this->withHtml($this->get($page->getUrl('/edit')));
+ $respHtml->assertElementContains('.comment-box .content', 'My great comment to see in the editor');
}
- private function checkResponse() {
- $expectedResp = [
- 'status' => 'success'
- ];
+ public function test_comment_creator_name_truncated()
+ {
+ [$longNamedUser] = $this->users->newUserWithRole(['name' => 'Wolfeschlegelsteinhausenbergerdorff'], ['comment-create-all', 'page-view-all']);
+ $page = $this->entities->page();
- $this->assertResponseOk();
- $this->seeJsonContains($expectedResp);
+ $comment = Comment::factory()->make();
+ $this->actingAs($longNamedUser)->postJson("/comment/$page->id", $comment->getAttributes());
- $resp = $this->decodeResponseJson();
- $createdComment = $resp['comment'];
- $this->assertArrayHasKey('id', $createdComment);
+ $pageResp = $this->asAdmin()->get($page->getUrl());
+ $pageResp->assertSee('Wolfeschlegels…');
+ }
- return $createdComment;
+ public function test_comment_editor_js_loaded_with_create_or_edit_permissions()
+ {
+ $editor = $this->users->editor();
+ $page = $this->entities->page();
+
+ $resp = $this->actingAs($editor)->get($page->getUrl());
+ $resp->assertSee('tinymce.min.js?', false);
+ $resp->assertSee('window.editor_translations', false);
+ $resp->assertSee('component="entity-selector"', false);
+
+ $this->permissions->removeUserRolePermissions($editor, ['comment-create-all']);
+ $this->permissions->grantUserRolePermissions($editor, ['comment-update-own']);
+
+ $resp = $this->actingAs($editor)->get($page->getUrl());
+ $resp->assertDontSee('tinymce.min.js?', false);
+ $resp->assertDontSee('window.editor_translations', false);
+ $resp->assertDontSee('component="entity-selector"', false);
+
+ Comment::factory()->create([
+ 'created_by' => $editor->id,
+ 'entity_type' => 'page',
+ 'entity_id' => $page->id,
+ ]);
+
+ $resp = $this->actingAs($editor)->get($page->getUrl());
+ $resp->assertSee('tinymce.min.js?', false);
+ $resp->assertSee('window.editor_translations', false);
+ $resp->assertSee('component="entity-selector"', false);
}
}
projects / bookstack / blobdiff