X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/43830a372fc51a8793199d04a34c3f4ebdfccc7b..refs/pull/3918/head:/app/Http/Controllers/Images/ImageController.php diff --git a/app/Http/Controllers/Images/ImageController.php b/app/Http/Controllers/Images/ImageController.php index 66ccadc5e..cd6b2d406 100644 --- a/app/Http/Controllers/Images/ImageController.php +++ b/app/Http/Controllers/Images/ImageController.php @@ -9,27 +9,16 @@ use BookStack\Uploads\Image; use BookStack\Uploads\ImageRepo; use BookStack\Uploads\ImageService; use Exception; -use Illuminate\Filesystem\Filesystem as File; -use Illuminate\Filesystem\FilesystemAdapter; use Illuminate\Http\Request; -use Illuminate\Support\Facades\Storage; use Illuminate\Validation\ValidationException; -use League\Flysystem\Util; class ImageController extends Controller { - protected $image; - protected $file; - protected $imageRepo; - protected $imageService; + protected ImageRepo $imageRepo; + protected ImageService $imageService; - /** - * ImageController constructor. - */ - public function __construct(Image $image, File $file, ImageRepo $imageRepo, ImageService $imageService) + public function __construct(ImageRepo $imageRepo, ImageService $imageService) { - $this->image = $image; - $this->file = $file; $this->imageRepo = $imageRepo; $this->imageService = $imageService; } @@ -41,7 +30,7 @@ class ImageController extends Controller */ public function showImage(string $path) { - if (!$this->imageService->pathExistsInLocalSecure($path)) { + if (!$this->imageService->pathAccessibleInLocalSecure($path)) { throw (new NotFoundException(trans('errors.image_not_found'))) ->setSubtitle(trans('errors.image_not_found_subtitle')) ->setDetails(trans('errors.image_not_found_details')); @@ -59,7 +48,7 @@ class ImageController extends Controller public function update(Request $request, string $id) { $this->validate($request, [ - 'name' => 'required|min:2|string', + 'name' => ['required', 'min:2', 'string'], ]); $image = $this->imageRepo->getById($id);