X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/80865b30a5d6a82e86d21e272ae58977d4430a64..refs/pull/1698/head:/app/Http/Controllers/ChapterController.php diff --git a/app/Http/Controllers/ChapterController.php b/app/Http/Controllers/ChapterController.php index 6b8a2f18f..f728d1313 100644 --- a/app/Http/Controllers/ChapterController.php +++ b/app/Http/Controllers/ChapterController.php @@ -1,30 +1,26 @@ bookRepo = $bookRepo; - $this->chapterRepo = $chapterRepo; + $this->entityRepo = $entityRepo; $this->userRepo = $userRepo; parent::__construct(); } @@ -36,33 +32,32 @@ class ChapterController extends Controller */ public function create($bookSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); + $book = $this->entityRepo->getEntityBySlug('book', $bookSlug); $this->checkOwnablePermission('chapter-create', $book); - $this->setPageTitle('Create New Chapter'); - return view('chapters/create', ['book' => $book, 'current' => $book]); + $this->setPageTitle(trans('entities.chapters_create')); + return view('chapters.create', ['book' => $book, 'current' => $book]); } /** * Store a newly created chapter in storage. - * @param $bookSlug - * @param Request $request + * @param Request $request + * @param string $bookSlug * @return Response + * @throws \BookStack\Exceptions\NotFoundException + * @throws \Illuminate\Validation\ValidationException */ - public function store($bookSlug, Request $request) + public function store(Request $request, string $bookSlug) { $this->validate($request, [ 'name' => 'required|string|max:255' ]); - $book = $this->bookRepo->getBySlug($bookSlug); + $book = $this->entityRepo->getEntityBySlug('book', $bookSlug); $this->checkOwnablePermission('chapter-create', $book); - $chapter = $this->chapterRepo->newFromInput($request->all()); - $chapter->slug = $this->chapterRepo->findSuitableSlug($chapter->name, $book->id); - $chapter->priority = $this->bookRepo->getNewPriority($book); - $chapter->created_by = auth()->user()->id; - $chapter->updated_by = auth()->user()->id; - $book->chapters()->save($chapter); + $input = $request->all(); + $input['priority'] = $this->entityRepo->getNewBookPriority($book); + $chapter = $this->entityRepo->createFromInput('chapter', $input, $book); Activity::add($chapter, 'chapter_create', $book->id); return redirect($chapter->getUrl()); } @@ -75,14 +70,14 @@ class ChapterController extends Controller */ public function show($bookSlug, $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); - $sidebarTree = $this->bookRepo->getChildren($book); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); + $this->checkOwnablePermission('chapter-view', $chapter); + $sidebarTree = $this->entityRepo->getBookChildren($chapter->book); Views::add($chapter); $this->setPageTitle($chapter->getShortName()); - $pages = $this->chapterRepo->getChildren($chapter); - return view('chapters/show', [ - 'book' => $book, + $pages = $this->entityRepo->getChapterChildren($chapter); + return view('chapters.show', [ + 'book' => $chapter->book, 'chapter' => $chapter, 'current' => $chapter, 'sidebarTree' => $sidebarTree, @@ -98,30 +93,27 @@ class ChapterController extends Controller */ public function edit($bookSlug, $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); $this->checkOwnablePermission('chapter-update', $chapter); - $this->setPageTitle('Edit Chapter' . $chapter->getShortName()); - return view('chapters/edit', ['book' => $book, 'chapter' => $chapter, 'current' => $chapter]); + $this->setPageTitle(trans('entities.chapters_edit_named', ['chapterName' => $chapter->getShortName()])); + return view('chapters.edit', ['book' => $chapter->book, 'chapter' => $chapter, 'current' => $chapter]); } /** * Update the specified chapter in storage. - * @param Request $request - * @param $bookSlug - * @param $chapterSlug + * @param Request $request + * @param string $bookSlug + * @param string $chapterSlug * @return Response + * @throws \BookStack\Exceptions\NotFoundException */ - public function update(Request $request, $bookSlug, $chapterSlug) + public function update(Request $request, string $bookSlug, string $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); $this->checkOwnablePermission('chapter-update', $chapter); - $chapter->fill($request->all()); - $chapter->slug = $this->chapterRepo->findSuitableSlug($chapter->name, $book->id, $chapter->id); - $chapter->updated_by = auth()->user()->id; - $chapter->save(); - Activity::add($chapter, 'chapter_update', $book->id); + + $this->entityRepo->updateFromInput($chapter, $request->all()); + Activity::add($chapter, 'chapter_update', $chapter->book->id); return redirect($chapter->getUrl()); } @@ -133,11 +125,10 @@ class ChapterController extends Controller */ public function showDelete($bookSlug, $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); $this->checkOwnablePermission('chapter-delete', $chapter); - $this->setPageTitle('Delete Chapter' . $chapter->getShortName()); - return view('chapters/delete', ['book' => $book, 'chapter' => $chapter, 'current' => $chapter]); + $this->setPageTitle(trans('entities.chapters_delete_named', ['chapterName' => $chapter->getShortName()])); + return view('chapters.delete', ['book' => $chapter->book, 'chapter' => $chapter, 'current' => $chapter]); } /** @@ -148,27 +139,89 @@ class ChapterController extends Controller */ public function destroy($bookSlug, $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); + $book = $chapter->book; $this->checkOwnablePermission('chapter-delete', $chapter); - Activity::addMessage('chapter_delete', $book->id, $chapter->name); - $this->chapterRepo->destroy($chapter); + Activity::addMessage('chapter_delete', $chapter->name, $book->id); + $this->entityRepo->destroyChapter($chapter); return redirect($book->getUrl()); } + /** + * Show the page for moving a chapter. + * @param $bookSlug + * @param $chapterSlug + * @return mixed + * @throws \BookStack\Exceptions\NotFoundException + */ + public function showMove($bookSlug, $chapterSlug) + { + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); + $this->setPageTitle(trans('entities.chapters_move_named', ['chapterName' => $chapter->getShortName()])); + $this->checkOwnablePermission('chapter-update', $chapter); + $this->checkOwnablePermission('chapter-delete', $chapter); + return view('chapters.move', [ + 'chapter' => $chapter, + 'book' => $chapter->book + ]); + } + + /** + * Perform the move action for a chapter. + * @param Request $request + * @param string $bookSlug + * @param string $chapterSlug + * @return mixed + * @throws \BookStack\Exceptions\NotFoundException + */ + public function move(Request $request, string $bookSlug, string $chapterSlug) + { + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); + $this->checkOwnablePermission('chapter-update', $chapter); + $this->checkOwnablePermission('chapter-delete', $chapter); + + $entitySelection = $request->get('entity_selection', null); + if ($entitySelection === null || $entitySelection === '') { + return redirect($chapter->getUrl()); + } + + $stringExploded = explode(':', $entitySelection); + $entityType = $stringExploded[0]; + $entityId = intval($stringExploded[1]); + + $parent = false; + + if ($entityType == 'book') { + $parent = $this->entityRepo->getById('book', $entityId); + } + + if ($parent === false || $parent === null) { + $this->showErrorNotification( trans('errors.selected_book_not_found')); + return redirect()->back(); + } + + $this->entityRepo->changeBook($chapter, $parent->id); + $chapter->rebuildPermissions(); + + Activity::add($chapter, 'chapter_move', $chapter->book->id); + $this->showSuccessNotification( trans('entities.chapter_move_success', ['bookName' => $parent->name])); + + return redirect($chapter->getUrl()); + } + /** * Show the Restrictions view. * @param $bookSlug * @param $chapterSlug * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View + * @throws \BookStack\Exceptions\NotFoundException */ - public function showRestrict($bookSlug, $chapterSlug) + public function showPermissions($bookSlug, $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); $this->checkOwnablePermission('restrictions-manage', $chapter); $roles = $this->userRepo->getRestrictableRoles(); - return view('chapters/restrictions', [ + return view('chapters.permissions', [ 'chapter' => $chapter, 'roles' => $roles ]); @@ -176,18 +229,19 @@ class ChapterController extends Controller /** * Set the restrictions for this chapter. - * @param $bookSlug - * @param $chapterSlug * @param Request $request + * @param string $bookSlug + * @param string $chapterSlug * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector + * @throws \BookStack\Exceptions\NotFoundException + * @throws \Throwable */ - public function restrict($bookSlug, $chapterSlug, Request $request) + public function permissions(Request $request, string $bookSlug, string $chapterSlug) { - $book = $this->bookRepo->getBySlug($bookSlug); - $chapter = $this->chapterRepo->getBySlug($chapterSlug, $book->id); + $chapter = $this->entityRepo->getEntityBySlug('chapter', $chapterSlug, $bookSlug); $this->checkOwnablePermission('restrictions-manage', $chapter); - $this->chapterRepo->updateRestrictionsFromRequest($request, $chapter); - session()->flash('success', 'Page Restrictions Updated'); + $this->entityRepo->updateEntityPermissionsFromRequest($request, $chapter); + $this->showSuccessNotification( trans('entities.chapters_permissions_success')); return redirect($chapter->getUrl()); } }