X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/f37a88620513480568f8d500a04ff590033d44de..refs/pull/73/head:/app/Services/ActivityService.php diff --git a/app/Services/ActivityService.php b/app/Services/ActivityService.php index 1691f06a1..a065ae01f 100644 --- a/app/Services/ActivityService.php +++ b/app/Services/ActivityService.php @@ -1,8 +1,8 @@ -activity = $activity; - $this->user = Auth::user(); + $this->user = auth()->user(); } /** * Add activity data to database. * @param Entity $entity - * @param $activityKey - * @param int $bookId - * @param bool $extra + * @param $activityKey + * @param int $bookId + * @param bool $extra */ public function add(Entity $entity, $activityKey, $bookId = 0, $extra = false) { - $this->activity->user_id = $this->user->id; - $this->activity->book_id = $bookId; - $this->activity->key = strtolower($activityKey); - if($extra !== false) { - $this->activity->extra = $extra; + $activity = $this->activity->newInstance(); + $activity->user_id = $this->user->id; + $activity->book_id = $bookId; + $activity->key = strtolower($activityKey); + if ($extra !== false) { + $activity->extra = $extra; } - $entity->activity()->save($this->activity); + $entity->activity()->save($activity); $this->setNotification($activityKey); } /** - * Adds a activity history with a message & without binding to a entitiy. - * @param $activityKey - * @param int $bookId + * Adds a activity history with a message & without binding to a entity. + * @param $activityKey + * @param int $bookId * @param bool|false $extra */ public function addMessage($activityKey, $bookId = 0, $extra = false) @@ -50,7 +51,7 @@ class ActivityService $this->activity->user_id = $this->user->id; $this->activity->book_id = $bookId; $this->activity->key = strtolower($activityKey); - if($extra !== false) { + if ($extra !== false) { $this->activity->extra = $extra; } $this->activity->save(); @@ -68,7 +69,7 @@ class ActivityService public function removeEntity(Entity $entity) { $activities = $entity->activity; - foreach($activities as $activity) { + foreach ($activities as $activity) { $activity->extra = $entity->name; $activity->entity_id = 0; $activity->entity_type = null; @@ -81,11 +82,67 @@ class ActivityService * Gets the latest activity. * @param int $count * @param int $page + * @return array */ public function latest($count = 20, $page = 0) { - return $this->activity->orderBy('created_at', 'desc') - ->skip($count*$page)->take($count)->get(); + $activityList = $this->activity->orderBy('created_at', 'desc') + ->skip($count * $page)->take($count)->get(); + return $this->filterSimilar($activityList); + } + + /** + * Gets the latest activity for an entity, Filtering out similar + * items to prevent a message activity list. + * @param Entity $entity + * @param int $count + * @param int $page + * @return array + */ + public function entityActivity($entity, $count = 20, $page = 0) + { + $activity = $entity->hasMany('BookStack\Activity')->orderBy('created_at', 'desc') + ->skip($count * $page)->take($count)->get(); + + return $this->filterSimilar($activity); + } + + /** + * Get latest activity for a user, Filtering out similar + * items. + * @param $user + * @param int $count + * @param int $page + * @return array + */ + public function userActivity($user, $count = 20, $page = 0) + { + $activity = $this->activity->where('user_id', '=', $user->id) + ->orderBy('created_at', 'desc')->skip($count * $page)->take($count)->get(); + return $this->filterSimilar($activity); + } + + /** + * Filters out similar activity. + * @param Activity[] $activities + * @return array + */ + protected function filterSimilar($activities) + { + $newActivity = []; + $previousItem = false; + foreach ($activities as $activityItem) { + if ($previousItem === false) { + $previousItem = $activityItem; + $newActivity[] = $activityItem; + continue; + } + if (!$activityItem->isSimilarTo($previousItem)) { + $newActivity[] = $activityItem; + } + $previousItem = $activityItem; + } + return $newActivity; } /**