]> BookStack Code Mirror - bookstack/commit
projects / bookstack / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7161f22)
OIDC: Fixed incorrect detection of group detail population
authorDan Brown <redacted>
Sun, 14 Jul 2024 13:21:16 +0000 (14:21 +0100)
committerDan Brown <redacted>
Sun, 14 Jul 2024 13:21:16 +0000 (14:21 +0100)
commit767699a0664c13fea1293654578f571ec4a08fa3
tree5ca2716a2e6bdd183a33d98e02e80b3e924873cftree | snapshot
parent7161f2270693cb91b930dd7dc646e933651f96facommit | diff
OIDC: Fixed incorrect detection of group detail population

An empty (but valid formed) groups list provided via the OIDC ID token
would be considered as a lacking detail, and therefore trigger a lookup
to the userinfo endpoint in an attempt to get that information.

This fixes this to properly distinguish between not-provided and empty
state, to avoid userinfo where provided as valid but empty.

Includes test to cover.
For #5101
app/Access/Oidc/OidcUserDetails.php diff | blob | history
tests/Auth/OidcTest.php diff | blob | history
The core source code for the BookStack project.