]> BookStack Code Mirror - bookstack/commit
Fixes issue with having to click the delete icon for attachment twice. 892/head
authorAbijeet <redacted>
Sun, 17 Jun 2018 08:51:31 +0000 (14:21 +0530)
committerAbijeet <redacted>
Sun, 17 Jun 2018 08:51:31 +0000 (14:21 +0530)
commit7d81a9515687aaff833ab76523a1b909fc21b764
tree2da8dcc046bf7118121d1f4db67bb8387bcd19c7
parentb3cc3130f092ce571f47a67bcd199ead18cdd1f9
Fixes issue with having to click the delete icon for attachment twice.

Fixes #884

This is happening because -

Due to the limitations of modern JavaScript (and the abandonment of Object.observe), Vue cannot detect property addition or deletion. Since Vue performs the getter/setter conversion process during instance initialization, a property must be present in the data object in order for Vue to convert it and make it reactive.

Source: https://vuejs.org/v2/guide/reactivity.html

Also added padding to the icons in the attachment section.

Signed-off-by: Abijeet <redacted>
resources/assets/js/vues/attachment-manager.js
resources/views/pages/form-toolbox.blade.php