]> BookStack Code Mirror - bookstack/commitdiff
Images: Added testing to cover animated avif handling 5625/head
authorDan Brown <redacted>
Fri, 23 May 2025 16:19:34 +0000 (17:19 +0100)
committerDan Brown <redacted>
Fri, 23 May 2025 16:19:34 +0000 (17:19 +0100)
tests/Uploads/ImageTest.php
tests/test-data/animated.avif [new file with mode: 0644]

index 2c36f5f356ed575d546ea640cab9e00b0e78749a..a2f03df34d4f62d12d163ea23378811418f6e58d 100644 (file)
@@ -68,7 +68,20 @@ class ImageTest extends TestCase
         $this->files->deleteAtRelativePath($imgDetails['path']);
 
         $this->assertStringContainsString('thumbs-', $imgDetails['response']->thumbs->gallery);
-        $this->assertStringNotContainsString('thumbs-', $imgDetails['response']->thumbs->display);
+        $this->assertStringNotContainsString('scaled-', $imgDetails['response']->thumbs->display);
+    }
+
+    public function test_image_display_thumbnail_generation_for_animated_avif_images_uses_original_file()
+    {
+        $page = $this->entities->page();
+        $admin = $this->users->admin();
+        $this->actingAs($admin);
+
+        $imgDetails = $this->files->uploadGalleryImageToPage($this, $page, 'animated.avif');
+        $this->files->deleteAtRelativePath($imgDetails['path']);
+
+        $this->assertStringContainsString('thumbs-', $imgDetails['response']->thumbs->gallery);
+        $this->assertStringNotContainsString('scaled-', $imgDetails['response']->thumbs->display);
     }
 
     public function test_image_edit()
diff --git a/tests/test-data/animated.avif b/tests/test-data/animated.avif
new file mode 100644 (file)
index 0000000..92f7145
Binary files /dev/null and b/tests/test-data/animated.avif differ