]> BookStack Code Mirror - bookstack/commitdiff
API: Fixed misaligned image datetime format
authorDan Brown <redacted>
Sat, 10 Jun 2023 09:52:39 +0000 (10:52 +0100)
committerDan Brown <redacted>
Sat, 10 Jun 2023 09:54:56 +0000 (10:54 +0100)
For #4294

app/Uploads/Controllers/ImageGalleryApiController.php
dev/api/responses/image-gallery-create.json
dev/api/responses/image-gallery-read.json
dev/api/responses/image-gallery-update.json
tests/Api/ImageGalleryApiTest.php

index 4fca6a4dd7d2fe28cacfd0f5227a21399b9100a7..c444ec663e81f5cfb7e895aa5c994dd202523d70 100644 (file)
@@ -129,7 +129,7 @@ class ImageGalleryApiController extends ApiController
     protected function formatForSingleResponse(Image $image): array
     {
         $this->imageRepo->loadThumbs($image);
-        $data = $image->getAttributes();
+        $data = $image->toArray();
         $data['created_by'] = $image->createdBy;
         $data['updated_by'] = $image->updatedBy;
         $data['content'] = [];
index e278244915cdae5bdb7661879e67110d29fc01ee..0bf36d368c6456c2984f52e4c0fa792e8d73df4e 100644 (file)
@@ -14,8 +14,8 @@
     "name": "Admin",
     "slug": "admin"
   },
-  "updated_at": "2023-03-15 08:17:37",
-  "created_at": "2023-03-15 08:17:37",
+  "updated_at": "2023-03-15T16:32:09.000000Z",
+  "created_at": "2023-03-15T16:32:09.000000Z",
   "id": 618,
   "thumbs": {
     "gallery": "https:\/\/p.rizon.top:443\/https\/bookstack.example.com\/uploads\/images\/gallery\/2023-03\/thumbs-150-150\/cute-cat-image.png",
index c6c468daa4fdad64945caaa96941b19efc755697..e3d5a92cab73601b15541f9cf0ce1a49696ce299 100644 (file)
@@ -2,8 +2,8 @@
   "id": 618,
   "name": "cute-cat-image.png",
   "url": "https:\/\/p.rizon.top:443\/https\/bookstack.example.com\/uploads\/images\/gallery\/2023-03\/cute-cat-image.png",
-  "created_at": "2023-03-15 08:17:37",
-  "updated_at": "2023-03-15 08:17:37",
+  "created_at": "2023-03-15T16:32:09.000000Z",
+  "updated_at": "2023-03-15T16:32:09.000000Z",
   "created_by": {
     "id": 1,
     "name": "Admin",
index 6e6168a1b184a450e08fec09e93f62afca5f42bb..e72961918320b742c278a7f81b753c6e2d9a8d79 100644 (file)
@@ -2,8 +2,8 @@
   "id": 618,
   "name": "My updated image name",
   "url": "https:\/\/p.rizon.top:443\/https\/bookstack.example.com\/uploads\/images\/gallery\/2023-03\/cute-cat-image.png",
-  "created_at": "2023-03-15 08:17:37",
-  "updated_at": "2023-03-15 08:24:50",
+  "created_at": "2023-03-15T16:32:09.000000Z",
+  "updated_at": "2023-03-15T18:31:14.000000Z",
   "created_by": {
     "id": 1,
     "name": "Admin",
index 067173a6b7d8260a276bf2156fea10bd4bcc8d7c..6670931074e83e46e5a8e56cf4b6a5dd98d32536 100644 (file)
@@ -232,6 +232,8 @@ class ImageGalleryApiTest extends TestCase
                 'html' => "<a href=\"{$image->url}\" target=\"_blank\"><img src=\"{$displayUrl}\" alt=\"{$image->name}\"></a>",
                 'markdown' => "![{$image->name}]({$displayUrl})",
             ],
+            'created_at' => $image->created_at->toISOString(),
+            'updated_at' => $image->updated_at->toISOString(),
         ]);
         $this->assertStringStartsWith('http://', $resp->json('thumbs.gallery'));
         $this->assertStringStartsWith('http://', $resp->json('thumbs.display'));