]> BookStack Code Mirror - bookstack/commitdiff
WYSIWYG: Fixed growing rows on Firefox
authorDan Brown <redacted>
Wed, 28 Jun 2023 22:28:31 +0000 (23:28 +0100)
committerDan Brown <redacted>
Wed, 28 Jun 2023 22:28:31 +0000 (23:28 +0100)
Occured when the cell contained any block content with a differnt line
height to the table cell itself.
In firefox, cells with a height would end up with an actual greater
real cell height, which messed up TinyMCE resize calculations, causing
tables to grow.
Adding default vertical-align: top, changes this behaviour to get proper
cell heights.
Related to Firefox issue: https://bugzilla.mozilla.org/show_bug.cgi?id=569645
Have tested that editor cell text align options can still be used with
this.

For #4337

resources/sass/_tables.scss

index 2aaa74d5f4a42ff74478633db1322cc4460d2f32..a3da3362122491903d49d7944ef2b2f180870970 100644 (file)
@@ -12,6 +12,7 @@ table {
     overflow: auto;
     line-height: 1.2;
        word-break: break-word;
+    vertical-align: top; // Workaround for: https://bugzilla.mozilla.org/show_bug.cgi?id=569645
   }
   td p, th p {
     margin: 0;