]> BookStack Code Mirror - bookstack/commitdiff
Merge branch 'Bajszi97/development' into development
authorDan Brown <redacted>
Wed, 13 Sep 2023 09:12:49 +0000 (10:12 +0100)
committerDan Brown <redacted>
Wed, 13 Sep 2023 09:12:49 +0000 (10:12 +0100)
app/Users/Models/User.php
tests/Entity/CommentTest.php

index 92701ac1312c89357c0cea0f07c9051f6ed0e493..2479521a2e91d86f046490ef346a488534001c7f 100644 (file)
@@ -345,7 +345,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
             return $splitName[0];
         }
 
-        return '';
+        return mb_substr($this->name, 0, max($chars - 2, 0)) . '…';
     }
 
     /**
index 0a71bb6eff4ab6167f70f21d9a610a6ab576829f..23fc68197411c220ccd4a173d14b11edee5aeed1 100644 (file)
@@ -152,4 +152,16 @@ class CommentTest extends TestCase
         $respHtml = $this->withHtml($this->get($page->getUrl('/edit')));
         $respHtml->assertElementContains('.comment-box .content', 'My great comment to see in the editor');
     }
+
+    public function test_comment_creator_name_truncated()
+    {
+        [$longNamedUser] = $this->users->newUserWithRole(['name' => 'Wolfeschlegelsteinhausenbergerdorff'], ['comment-create-all', 'page-view-all']);
+        $page = $this->entities->page();
+
+        $comment = Comment::factory()->make();
+        $this->actingAs($longNamedUser)->postJson("/comment/$page->id", $comment->getAttributes());
+
+        $pageResp = $this->asAdmin()->get($page->getUrl());
+        $pageResp->assertSee('Wolfeschlegels…');
+    }
 }