]> BookStack Code Mirror - bookstack/commitdiff
Updated tasklist style and functionality for cross-browser use
authorDan Brown <redacted>
Wed, 23 Mar 2022 11:51:19 +0000 (11:51 +0000)
committerDan Brown <redacted>
Wed, 23 Mar 2022 11:51:19 +0000 (11:51 +0000)
- Updated styles to better align checkboxes within page content.
- Updated functionality to use a cross-compatible property on checkbox
  click within the editor.

resources/js/wysiwyg/plugins-tasklist.js
resources/sass/_pages.scss

index 2dd6528e12d8b7b2816663c26d414e69d253b260..5b0e1c1f046563d8a0ff652d81e23df4a6775fbe 100644 (file)
@@ -84,9 +84,10 @@ function register(editor, url) {
 
     // Handle checkbox click in editor
     editor.on('click', function(event) {
-        const clickedEl = event.originalTarget;
+        const clickedEl = event.target;
         if (clickedEl.nodeName === 'LI' && clickedEl.classList.contains('task-list-item')) {
             handleTaskListItemClick(event, clickedEl, editor);
+            event.preventDefault();
         }
     });
 }
index 8103ca20d1c8ceb67b2626230ce79ae2c5b3664c..73819975fb6150fb9ffd66354f93a665416b533d 100755 (executable)
@@ -164,6 +164,11 @@ body.tox-fullscreen, body.markdown-fullscreen {
     clear: both;
   }
 
+  li > input[type="checkbox"] {
+    vertical-align: top;
+    margin-top: 0.3em;
+  }
+
   p:empty {
     min-height: 1.6em;
   }