]> BookStack Code Mirror - bookstack/commitdiff
Merge branch 'v23-08' into development
authorDan Brown <redacted>
Sat, 16 Sep 2023 10:55:57 +0000 (11:55 +0100)
committerDan Brown <redacted>
Sat, 16 Sep 2023 10:55:57 +0000 (11:55 +0100)
1  2 
tests/Activity/WatchTest.php

index 5db0067cc565b9789f6a9ce46db42832e46d15a9,464886155f4ae12fb2aeda9b1864cc7127bc4d54..5b9ae5a4c9e3d1996b652cab41f00675d7d9962a
@@@ -66,7 -66,7 +66,7 @@@ class WatchTest extends TestCas
  
          $this->actingAs($editor)->get($book->getUrl());
          $resp = $this->put('/watching/update', [
 -            'type' => get_class($book),
 +            'type' => $book->getMorphClass(),
              'id' => $book->id,
              'level' => 'comments'
          ]);
@@@ -81,7 -81,7 +81,7 @@@
          ]);
  
          $resp = $this->put('/watching/update', [
 -            'type' => get_class($book),
 +            'type' => $book->getMorphClass(),
              'id' => $book->id,
              'level' => 'default'
          ]);
          $book = $this->entities->book();
  
          $resp = $this->put('/watching/update', [
 -            'type' => get_class($book),
 +            'type' => $book->getMorphClass(),
              'id' => $book->id,
              'level' => 'comments'
          ]);
          $prefs = new UserNotificationPreferences($editor);
          $prefs->updateFromSettingsArray(['comment-replies' => 'true']);
  
+         // Create some existing comments to pad IDs to help potentially error
+         // on mis-identification of parent via ids used.
+         Comment::factory()->count(5)
+             ->for($entities['page'], 'entity')
+             ->create(['created_by' => $this->users->admin()->id]);
          $notifications = Notification::fake();
  
          $this->actingAs($editor)->post("/comment/{$entities['page']->id}", [
              'text' => 'My new comment'
          ]);
-         $comment = $entities['page']->comments()->first();
+         $comment = $entities['page']->comments()->orderBy('id', 'desc')->first();
  
          $this->asAdmin()->post("/comment/{$entities['page']->id}", [
              'text' => 'My new comment response',
-             'parent_id' => $comment->id,
+             'parent_id' => $comment->local_id,
          ]);
          $notifications->assertSentTo($editor, CommentCreationNotification::class);
      }