]> BookStack Code Mirror - bookstack/commitdiff
Testing: Added entity decode flag and phpunit env option 4497/head
authorDan Brown <redacted>
Sat, 2 Sep 2023 14:39:45 +0000 (15:39 +0100)
committerDan Brown <redacted>
Sat, 2 Sep 2023 14:39:45 +0000 (15:39 +0100)
- Passed decode flags to provide consistent behaviour across PHP
  versions during testing.
- Added env option to prevent local option taking action in PHPunit
  tests.

phpunit.xml
tests/Activity/WatchTest.php

index 704372c5c64f123a42702d62809653ceda95199c..183e456378caeb73a8d13b6c3159d0f422b39401 100644 (file)
@@ -21,6 +21,7 @@
     <server name="APP_AUTO_LANG_PUBLIC" value="true"/>
     <server name="APP_URL" value="http://bookstack.dev"/>
     <server name="ALLOWED_IFRAME_HOSTS" value=""/>
+    <server name="ALLOWED_SSR_HOSTS" value="*"/>
     <server name="CACHE_DRIVER" value="array"/>
     <server name="SESSION_DRIVER" value="array"/>
     <server name="QUEUE_CONNECTION" value="sync"/>
index d3c9387bbac2dd7c98f28cc81d27306885363dd7..72e6b37a58931ee35e75c7340fa272d8d21c6465 100644 (file)
@@ -257,7 +257,7 @@ class WatchTest extends TestCase
 
         $notifications->assertSentTo($editor, function (CommentCreationNotification $notification) use ($editor, $admin, $entities) {
             $mail = $notification->toMail($editor);
-            $mailContent = html_entity_decode(strip_tags($mail->render()));
+            $mailContent = html_entity_decode(strip_tags($mail->render()), ENT_QUOTES);
             return $mail->subject === 'New comment on page: ' . $entities['page']->getShortName()
                 && str_contains($mailContent, 'View Comment')
                 && str_contains($mailContent, 'Page Name: ' . $entities['page']->name)
@@ -280,7 +280,7 @@ class WatchTest extends TestCase
 
         $notifications->assertSentTo($editor, function (PageUpdateNotification $notification) use ($editor, $admin) {
             $mail = $notification->toMail($editor);
-            $mailContent = html_entity_decode(strip_tags($mail->render()));
+            $mailContent = html_entity_decode(strip_tags($mail->render()), ENT_QUOTES);
             return $mail->subject === 'Updated page: Updated page'
                 && str_contains($mailContent, 'View Page')
                 && str_contains($mailContent, 'Page Name: Updated page')
@@ -309,7 +309,7 @@ class WatchTest extends TestCase
 
         $notifications->assertSentTo($editor, function (PageCreationNotification $notification) use ($editor, $admin) {
             $mail = $notification->toMail($editor);
-            $mailContent = html_entity_decode(strip_tags($mail->render()));
+            $mailContent = html_entity_decode(strip_tags($mail->render()), ENT_QUOTES);
             return $mail->subject === 'New page: My new page'
                 && str_contains($mailContent, 'View Page')
                 && str_contains($mailContent, 'Page Name: My new page')
@@ -347,7 +347,7 @@ class WatchTest extends TestCase
             $notification = $notificationInfo[0]['notification'];
             $this->assertInstanceOf(BaseActivityNotification::class, $notification);
             $mail = $notification->toMail($editor);
-            $mailContent = html_entity_decode(strip_tags($mail->render()));
+            $mailContent = html_entity_decode(strip_tags($mail->render()), ENT_QUOTES);
             $this->assertStringContainsString('Name der Seite:', $mailContent);
             $this->assertStringContainsString('Diese Benachrichtigung wurde', $mailContent);
             $this->assertStringContainsString('Sollte es beim Anklicken der Schaltfläche', $mailContent);