Users: Hid lanuage preference for guest user

Hiding since it's not really used, and may mislead on how to set default
app language (which should be done via env options).
Updated test to cover.

For #5356

diff --git a/resources/views/users/edit.blade.php b/resources/views/users/edit.blade.php
index 2b736d81edeebad3b99ed0d59b391a98d0618b8b..611653d6a801ba7d2bec847344e258bfff13b0c2 100644 (file)
--- a/resources/views/users/edit.blade.php
+++ b/resources/views/users/edit.blade.php
@@ -34,7 +34,9 @@
                         </div>
                     </div>
 
-                    @include('users.parts.language-option-row', ['value' => old('language') ?? $user->getLocale()->appLocale()])
+                    @if(!$user->isGuest())
+                        @include('users.parts.language-option-row', ['value' => old('language') ?? $user->getLocale()->appLocale()])
+                    @endif
                 </div>
 
                 <div class="text-right">

diff --git a/tests/User/UserManagementTest.php b/tests/User/UserManagementTest.php
index 37d9b383544bbc66d5eeab3bead7b157ecc4fcb8..d92f13f0b3ff7624a58ba95298412a19bf6da152 100644 (file)
--- a/tests/User/UserManagementTest.php
+++ b/tests/User/UserManagementTest.php
@@ -202,9 +202,13 @@ class UserManagementTest extends TestCase
     public function test_guest_profile_shows_limited_form()
     {
         $guest = $this->users->guest();
+
         $resp = $this->asAdmin()->get('/settings/users/' . $guest->id);
         $resp->assertSee('Guest');
-        $this->withHtml($resp)->assertElementNotExists('#password');
+        $html = $this->withHtml($resp);
+
+        $html->assertElementNotExists('#password');
+        $html->assertElementNotExists('[name="language"]');
     }
 
     public function test_guest_profile_cannot_be_deleted()