]> BookStack Code Mirror - bookstack/commitdiff
Fixed broken favourites in code editor
authorDan Brown <redacted>
Mon, 1 May 2023 17:43:03 +0000 (18:43 +0100)
committerDan Brown <redacted>
Mon, 1 May 2023 17:43:03 +0000 (18:43 +0100)
resources/js/components/code-editor.js

index 9cedd2314ff53555cb668129fb55e66aa419ac0d..f9dc2b69ff9f8480b34f541a961b27bd17dbf786 100644 (file)
@@ -74,8 +74,13 @@ export class CodeEditor extends Component {
 
         onChildEvent(button.parentElement, '.lang-option-favorite-toggle', 'click', () => {
             isFavorite = !isFavorite;
-            const action = isFavorite ? this.favourites.add : this.favourites.delete;
-            action(language);
+
+            if (isFavorite) {
+                this.favourites.add(language);
+            } else {
+                this.favourites.delete(language);
+            }
+
             button.setAttribute('data-favourite', isFavorite ? 'true' : 'false');
 
             window.$http.patch('/preferences/update-code-language-favourite', {