]> BookStack Code Mirror - bookstack/commitdiff
Added page titles to many missing app areas 3141/head
authorDan Brown <redacted>
Tue, 4 Jan 2022 13:33:24 +0000 (13:33 +0000)
committerDan Brown <redacted>
Tue, 4 Jan 2022 13:33:24 +0000 (13:33 +0000)
Many pages were missing their unique tab/page titles
so this change is just to distribute them back over
many common areas where they were missing.

app/Http/Controllers/Auth/MfaBackupCodesController.php
app/Http/Controllers/Auth/MfaController.php
app/Http/Controllers/Auth/MfaTotpController.php
app/Http/Controllers/FavouriteController.php
app/Http/Controllers/PageController.php
app/Http/Controllers/RoleController.php
app/Http/Controllers/TagController.php
app/Http/Controllers/UserProfileController.php
app/Http/Controllers/WebhookController.php

index e240900229983e5834f47ddc035517f26dce1396..4ceb394b0b864297c4aadcf763046f9376d89f3f 100644 (file)
@@ -29,6 +29,8 @@ class MfaBackupCodesController extends Controller
 
         $downloadUrl = 'data:application/octet-stream;base64,' . base64_encode(implode("\n\n", $codes));
 
+        $this->setPageTitle(trans('auth.mfa_gen_backup_codes_title'));
+
         return view('mfa.backup-codes-generate', [
             'codes'       => $codes,
             'downloadUrl' => $downloadUrl,
index ca77cc70807ae9b1a0a4cb31dfb1a1575ef47165..6f6beb873e4911c6a509450694550edbe98cc953 100644 (file)
@@ -21,6 +21,8 @@ class MfaController extends Controller
             ->get(['id', 'method'])
             ->groupBy('method');
 
+        $this->setPageTitle(trans('auth.mfa_setup'));
+
         return view('mfa.setup', [
             'userMethods' => $userMethods,
         ]);
index 5644f02688e8618a99e0599bb60eb3cb1b68f82e..a4cb63155a138f9b172bca736caeaace79ddb030 100644 (file)
@@ -34,6 +34,8 @@ class MfaTotpController extends Controller
         $qrCodeUrl = $totp->generateUrl($totpSecret, $this->currentOrLastAttemptedUser());
         $svg = $totp->generateQrCodeSvg($qrCodeUrl);
 
+        $this->setPageTitle(trans('auth.mfa_gen_totp_title'));
+
         return view('mfa.totp-generate', [
             'url' => $qrCodeUrl,
             'svg' => $svg,
index 8643073c953fe50e59318268f3ba8faed3e474d1..b4cbdf5c2aa35f1eea2507a3e14fd8aedca9563e 100644 (file)
@@ -21,6 +21,8 @@ class FavouriteController extends Controller
 
         $hasMoreLink = ($favourites->count() > $viewCount) ? url('/favourites?page=' . ($page + 1)) : null;
 
+        $this->setPageTitle(trans('entities.my_favourites'));
+
         return view('common.detailed-listing-with-more', [
             'title'       => trans('entities.my_favourites'),
             'entities'    => $favourites->slice(0, $viewCount),
index 84187f7451dadd736515262eb9ab029aebfac2eb..3e57657da7199e6b5da0046b1c6f6008c50c932b 100644 (file)
@@ -368,6 +368,8 @@ class PageController extends Controller
             ->paginate(20)
             ->setPath(url('/pages/recently-updated'));
 
+        $this->setPageTitle(trans('entities.recently_updated_pages'));
+
         return view('common.detailed-listing-paginated', [
             'title'    => trans('entities.recently_updated_pages'),
             'entities' => $pages,
index 7c72b59707abc6b888c020bd680a9f91b47be541..ea117c0009bcd4cbeb73e0806928aeb09b27e7ee 100644 (file)
@@ -29,6 +29,7 @@ class RoleController extends Controller
         $this->checkPermission('user-roles-manage');
         $roles = $this->permissionsRepo->getAllRoles();
 
+        $this->setPageTitle(trans('settings.roles'));
         return view('settings.roles.index', ['roles' => $roles]);
     }
 
@@ -49,6 +50,7 @@ class RoleController extends Controller
             $role->display_name .= ' (' . trans('common.copy') . ')';
         }
 
+        $this->setPageTitle(trans('settings.role_create'));
         return view('settings.roles.create', ['role' => $role]);
     }
 
@@ -82,6 +84,7 @@ class RoleController extends Controller
             throw new PermissionsException(trans('errors.role_cannot_be_edited'));
         }
 
+        $this->setPageTitle(trans('settings.role_edit'));
         return view('settings.roles.edit', ['role' => $role]);
     }
 
@@ -116,6 +119,7 @@ class RoleController extends Controller
         $blankRole = $role->newInstance(['display_name' => trans('settings.role_delete_no_migration')]);
         $roles->prepend($blankRole);
 
+        $this->setPageTitle(trans('settings.role_delete'));
         return view('settings.roles.delete', ['role' => $role, 'roles' => $roles]);
     }
 
index 1fe32e5caf1f64ee9067972b532afdb44f250059..e59580b6065a2a816f3a2b6fade8526e62d80ef4 100644 (file)
@@ -32,6 +32,8 @@ class TagController extends Controller
                 'name'   => $nameFilter,
             ]));
 
+        $this->setPageTitle(trans('entities.tags'));
+
         return view('tags.index', [
             'tags'       => $tags,
             'search'     => $search,
index 63565f3b20e189180b75d12124498442817b9192..5fd8f7b888963d9c7e087fcf94e7f4fc18e10435 100644 (file)
@@ -18,6 +18,8 @@ class UserProfileController extends Controller
         $recentlyCreated = $repo->getRecentlyCreated($user, 5);
         $assetCounts = $repo->getAssetCounts($user);
 
+        $this->setPageTitle($user->name);
+
         return view('users.profile', [
             'user'            => $user,
             'activity'        => $userActivity,
index 81e3b77925aa7d4827503126475d5196413756aa..1a4fa79d7b6b369bcfb9b64990e0aaba8e062d26 100644 (file)
@@ -25,6 +25,8 @@ class WebhookController extends Controller
             ->with('trackedEvents')
             ->get();
 
+        $this->setPageTitle(trans('settings.webhooks'));
+
         return view('settings.webhooks.index', ['webhooks' => $webhooks]);
     }
 
@@ -33,6 +35,7 @@ class WebhookController extends Controller
      */
     public function create()
     {
+        $this->setPageTitle(trans('settings.webhooks_create'));
         return view('settings.webhooks.create');
     }
 
@@ -69,6 +72,8 @@ class WebhookController extends Controller
             ->with('trackedEvents')
             ->findOrFail($id);
 
+        $this->setPageTitle(trans('settings.webhooks_edit'));
+
         return view('settings.webhooks.edit', ['webhook' => $webhook]);
     }
 
@@ -105,6 +110,8 @@ class WebhookController extends Controller
         /** @var Webhook $webhook */
         $webhook = Webhook::query()->findOrFail($id);
 
+        $this->setPageTitle(trans('settings.webhooks_delete'));
+
         return view('settings.webhooks.delete', ['webhook' => $webhook]);
     }