From: Dan Brown <redacted>
Date: Sat, 23 Apr 2022 13:22:04 +0000 (+0100)
Subject: Aded tests for core editor switching functionality
X-Git-Tag: v22.04~1^2~13^2~3
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/1b46aa87565547ff7af21dfec1c2d7d89ff4873d?ds=inline

Aded tests for core editor switching functionality
---

diff --git a/resources/views/home/default.blade.php b/resources/views/home/default.blade.php
index 4e14b6744..6435e4ebd 100644
--- a/resources/views/home/default.blade.php
+++ b/resources/views/home/default.blade.php
@@ -17,15 +17,6 @@
         </div>
     </div>
 
-    @component('common.confirm-dialog', ['title' => 'Destroy Dogs'])
-        <p>Are you sure you want to do this thingy?</p>
-        <ul>
-            <li>This could be bad</li>
-            <li>This could be very bad</li>
-            <li>This might be very bad</li>
-        </ul>
-    @endcomponent
-
     <script nonce="{{ $cspNonce }}">
         setTimeout(async () => {
             const result = await window.components["confirm-dialog"][0].show();
diff --git a/tests/Entity/PageEditorTest.php b/tests/Entity/PageEditorTest.php
index c06aa5bf1..f489e6b03 100644
--- a/tests/Entity/PageEditorTest.php
+++ b/tests/Entity/PageEditorTest.php
@@ -102,4 +102,86 @@ class PageEditorTest extends TestCase
         $resp = $this->get($draft->getUrl('/edit'));
         $resp->assertElementContains('a[href="' . $draft->getUrl() . '"]', 'Back');
     }
+
+    public function test_switching_from_html_to_clean_markdown_works()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+        $page->html = '<h2>A Header</h2><p>Some <strong>bold</strong> content.</p>';
+        $page->save();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit?editor=markdown-clean'));
+        $resp->assertStatus(200);
+        $resp->assertSee("## A Header\n\nSome **bold** content.");
+        $resp->assertElementExists('#markdown-editor');
+    }
+
+    public function test_switching_from_html_to_stable_markdown_works()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+        $page->html = '<h2>A Header</h2><p>Some <strong>bold</strong> content.</p>';
+        $page->save();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit?editor=markdown-stable'));
+        $resp->assertStatus(200);
+        $resp->assertSee("<h2>A Header</h2><p>Some <strong>bold</strong> content.</p>", true);
+        $resp->assertElementExists('[component="markdown-editor"]');
+    }
+
+    public function test_switching_from_markdown_to_wysiwyg_works()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+        $page->html = '';
+        $page->markdown = "## A Header\n\nSome content with **bold** text!";
+        $page->save();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit?editor=wysiwyg'));
+        $resp->assertStatus(200);
+        $resp->assertElementExists('[component="wysiwyg-editor"]');
+        $resp->assertSee("<h2>A Header</h2>\n<p>Some content with <strong>bold</strong> text!</p>", true);
+    }
+
+    public function test_page_editor_depends_on_content_type()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit'));
+        $resp->assertElementExists('[component="wysiwyg-editor"]');
+
+        $page->html = '';
+        $page->markdown = "## A Header\n\nSome content with **bold** text!";
+        $page->save();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit'));
+        $resp->assertElementExists('[component="markdown-editor"]');
+    }
+
+    public function test_editor_type_switch_options_show()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit'));
+        $editLink = $page->getUrl('/edit') . '?editor=';
+        $resp->assertElementContains("a[href=\"${editLink}markdown-clean\"]", '(Clean Content)');
+        $resp->assertElementContains("a[href=\"${editLink}markdown-stable\"]", '(Stable Content)');
+
+        $resp = $this->asAdmin()->get($page->getUrl('/edit?editor=markdown-stable'));
+        $editLink = $page->getUrl('/edit') . '?editor=';
+        $resp->assertElementContains("a[href=\"${editLink}wysiwyg\"]", 'Switch to WYSIWYG Editor');
+    }
+
+    public function test_editor_type_switch_options_dont_show_if_without_change_editor_permissions()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+
+        $resp = $this->asEditor()->get($page->getUrl('/edit'));
+        $editLink = $page->getUrl('/edit') . '?editor=';
+        $resp->assertElementNotExists("a[href*=\"${editLink}\"]");
+    }
+
 }