From: Dan Brown <redacted>
Date: Sun, 6 Dec 2020 21:32:01 +0000 (+0000)
Subject: Merge branch 'v0.30.x'
X-Git-Tag: v0.31.0~3^2~25
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/65b2c905229ebdd1c34614125551dde25d714840

Merge branch 'v0.30.x'
---

65b2c905229ebdd1c34614125551dde25d714840
diff --cc tests/Entity/ExportTest.php
index e022f92f5,b1e6eb5fb..7c56a7268
--- a/tests/Entity/ExportTest.php
+++ b/tests/Entity/ExportTest.php
@@@ -1,9 -1,8 +1,9 @@@
  <?php namespace Tests\Entity;
  
 -use BookStack\Entities\Chapter;
 -use BookStack\Entities\Page;
 +
 +use BookStack\Entities\Models\Chapter;
 +use BookStack\Entities\Models\Page;
- use BookStack\Uploads\HttpFetcher;
+ use Illuminate\Support\Facades\Storage;
  use Illuminate\Support\Str;
  use Tests\TestCase;
  
@@@ -164,4 -166,26 +167,26 @@@ class ExportTest extends TestCas
          $resp->assertSee('<img src="data:image/svg+xml;base64');
      }
  
- }
+     public function test_page_export_contained_html_image_fetches_only_run_when_url_points_to_image_upload_folder()
+     {
+         $page = Page::first();
+         $page->html = '<img src="http://localhost/uploads/images/gallery/svg_test.svg"/>'
+             ."\n".'<img src="http://localhost/uploads/svg_test.svg"/>'
+             ."\n".'<img src="/https/source.bookstackapp.com/uploads/svg_test.svg"/>';
+         $storageDisk = Storage::disk('local');
+         $storageDisk->makeDirectory('uploads/images/gallery');
+         $storageDisk->put('uploads/images/gallery/svg_test.svg', '<svg>good</svg>');
+         $storageDisk->put('uploads/svg_test.svg', '<svg>bad</svg>');
+         $page->save();
+ 
+         $resp = $this->asEditor()->get($page->getUrl('/export/html'));
+ 
+         $storageDisk->delete('uploads/images/gallery/svg_test.svg');
+         $storageDisk->delete('uploads/svg_test.svg');
+ 
+         $resp->assertDontSee('http://localhost/uploads/images/gallery/svg_test.svg');
+         $resp->assertSee('http://localhost/uploads/svg_test.svg');
+         $resp->assertSee('src="/uploads/svg_test.svg"');
+     }
+ 
 -}
++}