From: Dan Brown <redacted>
Date: Tue, 23 Jan 2024 15:01:07 +0000 (+0000)
Subject: Attachment List: Fixed broken ctrl-click functionality
X-Git-Tag: v23.12.2~1^2~4
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/788327fffb044a03ccc490be0bcddd48e3551b01

Attachment List: Fixed broken ctrl-click functionality

Fixes #4782
---

diff --git a/resources/js/components/attachments-list.js b/resources/js/components/attachments-list.js
index 4db09977f..665904f86 100644
--- a/resources/js/components/attachments-list.js
+++ b/resources/js/components/attachments-list.js
@@ -9,6 +9,8 @@ export class AttachmentsList extends Component {
 
     setup() {
         this.container = this.$el;
+        this.fileLinks = this.$manyRefs.linkTypeFile;
+
         this.setupListeners();
     }
 
@@ -27,8 +29,7 @@ export class AttachmentsList extends Component {
     }
 
     addOpenQueryToLinks() {
-        const links = this.container.querySelectorAll('a.attachment-file');
-        for (const link of links) {
+        for (const link of this.fileLinks) {
             if (link.href.split('?')[1] !== 'open=true') {
                 link.href += '?open=true';
                 link.setAttribute('target', '_blank');
@@ -37,8 +38,7 @@ export class AttachmentsList extends Component {
     }
 
     removeOpenQueryFromLinks() {
-        const links = this.container.querySelectorAll('a.attachment-file');
-        for (const link of links) {
+        for (const link of this.fileLinks) {
             link.href = link.href.split('?')[0];
             link.removeAttribute('target');
         }
diff --git a/resources/views/attachments/list.blade.php b/resources/views/attachments/list.blade.php
index a6ffb709b..71197cc19 100644
--- a/resources/views/attachments/list.blade.php
+++ b/resources/views/attachments/list.blade.php
@@ -2,7 +2,9 @@
     @foreach($attachments as $attachment)
         <div class="attachment icon-list">
             <div class="split-icon-list-item attachment-{{ $attachment->external ? 'link' : 'file' }}">
-                <a href="{{ $attachment->getUrl() }}" @if($attachment->external) target="_blank" @endif>
+                <a href="{{ $attachment->getUrl() }}"
+                   refs="attachments-list@link-type-{{ $attachment->external ? 'link' : 'file' }}"
+                   @if($attachment->external) target="_blank" @endif>
                     <div class="icon">@icon($attachment->external ? 'export' : 'file')</div>
                     <div class="label">{{ $attachment->name }}</div>
                 </a>