From: Dan Brown <redacted>
Date: Mon, 7 Oct 2019 19:21:04 +0000 (+0100)
Subject: Updated comment delete action to be a button
X-Git-Tag: v0.27.5~1^2~2
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/b6c0baf44d7d737ede7784848374a8af3e911ac1

Updated comment delete action to be a button

Fixes issue that causes code error when an anchor tag.

Closes #1650
---

diff --git a/resources/assets/js/components/page-comments.js b/resources/assets/js/components/page-comments.js
index cabce9139..5d8d16958 100644
--- a/resources/assets/js/components/page-comments.js
+++ b/resources/assets/js/components/page-comments.js
@@ -26,10 +26,12 @@ class PageComments {
 
     handleAction(event) {
         let actionElem = event.target.closest('[action]');
+
         if (event.target.matches('a[href^="#"]')) {
             const id = event.target.href.split('#')[1];
             scrollAndHighlightElement(document.querySelector('#' + id));
         }
+
         if (actionElem === null) return;
         event.preventDefault();
 
diff --git a/resources/views/comments/comment.blade.php b/resources/views/comments/comment.blade.php
index 5fbdfa500..ea96a9250 100644
--- a/resources/views/comments/comment.blade.php
+++ b/resources/views/comments/comment.blade.php
@@ -31,7 +31,7 @@
                         <button type="button" dropdown-toggle aria-haspopup="true" aria-expanded="false" class="text-button" title="{{ trans('common.delete') }}">@icon('delete')</button>
                         <ul class="dropdown-menu" role="menu">
                             <li class="px-m text-small text-muted pb-s">{{trans('entities.comment_delete_confirm')}}</li>
-                            <li><a action="delete" href="#" class="text-button text-neg" >@icon('delete'){{ trans('common.delete') }}</a></li>
+                            <li><button action="delete" type="button" class="text-button text-neg" >@icon('delete'){{ trans('common.delete') }}</button></li>
                         </ul>
                     </div>
                 @endif