From: Dan Brown <redacted>
Date: Mon, 1 May 2023 17:43:03 +0000 (+0100)
Subject: Fixed broken favourites in code editor
X-Git-Tag: v23.05~1^2~5
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/cd32597d4d4bd4ef895798d188dce0027d0a2337

Fixed broken favourites in code editor
---

diff --git a/resources/js/components/code-editor.js b/resources/js/components/code-editor.js
index 9cedd2314..f9dc2b69f 100644
--- a/resources/js/components/code-editor.js
+++ b/resources/js/components/code-editor.js
@@ -74,8 +74,13 @@ export class CodeEditor extends Component {
 
         onChildEvent(button.parentElement, '.lang-option-favorite-toggle', 'click', () => {
             isFavorite = !isFavorite;
-            const action = isFavorite ? this.favourites.add : this.favourites.delete;
-            action(language);
+
+            if (isFavorite) {
+                this.favourites.add(language);
+            } else {
+                this.favourites.delete(language);
+            }
+
             button.setAttribute('data-favourite', isFavorite ? 'true' : 'false');
 
             window.$http.patch('/preferences/update-code-language-favourite', {