From: Dan Brown <redacted>
Date: Sat, 18 Sep 2021 20:29:42 +0000 (+0100)
Subject: Fixed dodgy test helper signature causing tests to fail
X-Git-Tag: v21.08.4~1^2~12
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/ffdfdc7449a059c9d8a69ad2fa19d43a758c7794

Fixed dodgy test helper signature causing tests to fail

Just needed some argument defaults to make them optional for existing
uses.
---

diff --git a/tests/TestCase.php b/tests/TestCase.php
index 30b07da0f..98e0dfbac 100644
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -62,7 +62,7 @@ abstract class TestCase extends BaseTestCase
      * Assert that an activity entry exists of the given key.
      * Checks the activity belongs to the given entity if provided.
      */
-    protected function assertActivityExists(string $type, ?Entity $entity, ?string $detail)
+    protected function assertActivityExists(string $type, ?Entity $entity = null, string $detail = '')
     {
         $detailsToCheck = ['type' => $type];