From: Dan Brown <redacted>
Date: Sun, 19 Feb 2023 16:03:50 +0000 (+0000)
Subject: Fixed unselectable checkbox role form options
X-Git-Tag: v23.02~1^2~11^2
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/refs/pull/4051/head?ds=sidebyside

Fixed unselectable checkbox role form options
---

diff --git a/app/Http/Controllers/RoleController.php b/app/Http/Controllers/RoleController.php
index 2bf0a7b19..135ba329f 100644
--- a/app/Http/Controllers/RoleController.php
+++ b/app/Http/Controllers/RoleController.php
@@ -116,14 +116,8 @@ class RoleController extends Controller
             'mfa_enforced' => ['string'],
         ]);
 
-        if (isset($data['permissions'])) {
-            $data['permissions'] = array_keys($data['permissions']);
-        }
-
-        if (isset($data['mfa_enforced'])) {
-            $data['mfa_enforced'] = $data['mfa_enforced'] === 'true';
-        }
-
+        $data['permissions'] = array_keys($data['permissions'] ?? []);
+        $data['mfa_enforced'] = ($data['mfa_enforced'] ?? 'false') === 'true';
         $this->permissionsRepo->updateRole($id, $data);
 
         return redirect('/settings/roles');