Dan Brown [Mon, 23 May 2022 14:16:23 +0000 (15:16 +0100)]
Replaced markdown preview display iframe with div
No longer need to use the iframe sandboxing techniques, since we now have
CSP rules in-place. Means that embed tags can load without CSP
complications.
Causes slight change to contents of `editor-markdown::setup` editor
event data, since we're changing the `displayEl` property.
Updates markdown editor component to make better use of the component
system.
Dan Brown [Mon, 23 May 2022 11:24:40 +0000 (12:24 +0100)]
Updated drawio tinymce plugin to use embeds
- Adds support for handling drawings as embeds, based on image
extension.
- Adds additional attribute to drawio elements within editor to prevent
tinymce replacing embeds with a placeholder.
- Updates how contenteditable is applied to drawio blocks within editor,
to use proper filters instead of using the SetContent event.
Dan Brown [Mon, 16 May 2022 13:05:21 +0000 (14:05 +0100)]
Fixed entity-specific tag counts listing
Was reporting wrong due to use of old polymorphic namespace references.
Test was not picking up as assertElementContains had wider scope than
expected, looking within the HTML of the element instead of the text
which you might expect. Updated test helper to look at text instead.
Dan Brown [Wed, 11 May 2022 15:46:59 +0000 (16:46 +0100)]
Updated default value for secure session detection
Updated default value for APP_URL so that the startsWith call is not
passed null, since that causes deprecation notice in PHP8.1.
Would show when APP_URL was not set, adding extra confusiion.
Dan Brown [Mon, 9 May 2022 14:57:50 +0000 (15:57 +0100)]
Fixed LDAP_DUMP_* options when data contains binary
Dumping details that were binary, such as the jpegphoto data, would
cause the dump to fail on the encoding to JSON.
This change forces content to be UTF8 before dumping.
Updated existing test to cover.
Dan Brown [Mon, 9 May 2022 14:25:06 +0000 (15:25 +0100)]
Updated attachment download to check OB before cleaning it
Call to `ob_end_clean` would error if the environment did not use the
PHP `output_buffering` option. This adds an additional check and updates
the comment to be more specific to the exact scenario of the condition.
Tested with output_buffering=Off and output_buffering=4096
Dan Brown [Mon, 25 Apr 2022 16:54:59 +0000 (17:54 +0100)]
Reviewed recycle bin API PR and made changes
Made the following changes, many of these are just to align with
existing conventions.
- Updated urls to be hypenated, instead of underscored, to match other system endpoints.
- Updated URL parameter to be `deletionId` instead of `id`, and removed the ID-based comment on controller methods, so the required ID model is clear from the URL alone, since its not clear from the URL endpoint alone like existing endpoints. This follows the pattern used in the "web" routes.
- Added extra detail on some controller method comments, and copied permission comment to each method.
- Removed existing field visibility mechanisms to use simpler model-based visibility since we didn't need anything too special here (After some of my other changes).
- Allowed the "deletable" model to be shown in response to provide a little more detail on the main deleted item.
- Updated parent/child-count loading to be on the "deletable" model instead of additional properties which results in simpler controller logic and enforces the idea these are relations on the deletable, not the deletion itself. It also removes additional exposure of model namespacing.
- Updated (int) casts to intval, just since that's our most common conversion method in the codebase.
- Testing: Removed `actingAsAuthorizedUser` and used the admin user instead to prevent extra auth steps on each test.
- Testing: Cut logic/data-checks from tests if already covered by other tests.
- Testing: Added simple assertions for delete/restore response data.
- Examples: Updated list example to reflect changes.
Review of PR #3377
To be followed up with changes to polymorphic relations to hide
namespacing.
Dan Brown [Wed, 20 Apr 2022 13:03:47 +0000 (14:03 +0100)]
Standardised dropdown list item styles, Extracted page editor toolbar
- Updated all dropdown list item actions into three specific styles:
icon-item, text-item & label-item. Allows a stronger structure while
prevents mixing of styles as we were getting for header dropdown in
dark mode.
- Extracted out page editor top toolbar to its own view file & split
editor switch options to different markdown options.
Dan Brown [Sun, 17 Apr 2022 22:01:14 +0000 (23:01 +0100)]
Aligned page edit controller method data usage
Extracted page editor view data gathering to its own class for
alignment. Updated the data used in views as part of the process to use
view-specific variables instead of custom attributes added to models.
Also moved tinymce library loading so it's not loaded when not using the
wysiwyg editor.
Dan Brown [Wed, 13 Apr 2022 11:08:56 +0000 (12:08 +0100)]
Extracted esbuild config to a build script
Allows us to use NodeJS code for file/directory locating to not be
shell/os specific, while also also reducing duplicated complexity within
packages.json file.
Dan Brown [Sun, 3 Apr 2022 15:22:31 +0000 (16:22 +0100)]
Fixed tests from streaming changes
- Added testing check to buffer stop/clear on streaming output due to
interference during tests.
- Made content-disposition header a little safer in download responses.
- Also aligned how we check for testing environment.
Dan Brown [Sat, 2 Apr 2022 17:42:15 +0000 (18:42 +0100)]
Fixed streamed outputs in more extreme scenarios
Fixes hitting memory limits where downloaded file sizes are much greater
than memory limit. Stopping and flushing output buffer seemed to stop
limits causing issues when fpassthru is used.
Tested with 24M memory limit and 734M file
Dan Brown [Sat, 2 Apr 2022 16:14:37 +0000 (17:14 +0100)]
Updated custom request overrides to better match original intent
This updates the custom Request handler to provide only the scheme and
host on the `getSchemeAndHttpHost` call, instead of providing the whole
APP_URL value, while adding an override to the 'getBaseUrl' to use the
APP_URL content instead of the guessed/detected Symfony value.
Dan Brown [Wed, 30 Mar 2022 18:15:24 +0000 (19:15 +0100)]
Fixed settings redirect issue and custom head display
- Fixed issue where redirect for `/settings` view would not be ran
through base url generator so would not create a correct path in some
cases. Now routed through controller with normal redirect.
- Fixed custom head content being active on settings pages due to route
name changes, for when viewing settings, in last release.
Dan Brown [Mon, 28 Mar 2022 10:31:06 +0000 (11:31 +0100)]
PHPStan and StyleCI fixes
- Updated PhpStan PHP version option to match project.
- Applied StyleCI changes.
- Updated static to self in WebhookFormatter, following static analysis
guidance.
- Fixed mis-matched header tags.
Dan Brown [Mon, 28 Mar 2022 10:09:55 +0000 (11:09 +0100)]
Split out settings view and made functional
- Split settings out to new views using a core shared layout.
- Extracted added language text to translation files.
- Updated settings routes to be dynamic to category.
- Added redirect for old primary settings route.
- Updated existing tests to cover settings route changes.
- Added tests to cover settings view.
- Improved contrast of settings links for dark mode.
Dan Brown [Sat, 26 Mar 2022 16:44:34 +0000 (16:44 +0000)]
Added extendable/scalable formatter for webhook data
Creates a new organsied formatting system for webhook data, with
interfaces for extending with custom model formatting rules.
Allows easy usage & extension of the default bookstack formatting
behaviour when customizing webhook events via theme system, and keeps
default data customizations organised.
This also makes the following webhook data changes:
- owned_by/created_by/updated_by user details are loaded for events with
Entity details. (POTENTIALLY BREAKING CHANGE).
- current_revision details are loaded for page update/create events.
Added testing to cover added model formatting rules.
Uses original image data to extract orientation exif to apply image
transformations before scaling and save. Manually done due to issues
with exif data loss during the existing Invervention image path.
Dan Brown [Fri, 25 Mar 2022 11:13:04 +0000 (11:13 +0000)]
Added pre-render sizes to wysiwyg code blocks
Sets sizes on WYSIWYG code block sections based on content lines
as an early pre-codemirror height prediction to avoid excessive
jumping in the editor.
Dan Brown [Wed, 23 Mar 2022 15:11:14 +0000 (15:11 +0000)]
Added wysiwyg filter to handle <br> tags within code blocks
This filters out <br> elements within code blocks and replaces them with
newlines. The editor started using <br>'s more harshley after some
configuration changes upon upgrading tinymce, in which we standardised
on forced br tags to avoid empty elements.
Dan Brown [Wed, 23 Mar 2022 11:51:19 +0000 (11:51 +0000)]
Updated tasklist style and functionality for cross-browser use
- Updated styles to better align checkboxes within page content.
- Updated functionality to use a cross-compatible property on checkbox
click within the editor.
projects / bookstack / log