]> BookStack Code Mirror - bookstack/log
bookstack
2 years agoAdded method for using enity ownership in relation queries user_permissions 3908/head
Dan Brown [Sun, 15 Jan 2023 17:38:08 +0000 (17:38 +0000)]
Added method for using enity ownership in relation queries

It has a large linear-entity-scaling performance impact though.

2 years agoAttempted fix of issues, realised new query system is a failure
Dan Brown [Sat, 14 Jan 2023 13:50:41 +0000 (13:50 +0000)]
Attempted fix of issues, realised new query system is a failure

As part of the permission checking we need to check owner user status.
Upon this, we'd also want to check page draft status (and its
creator/owner).
These, for cross-entity/relation queries would need up to another 4 joins.
The performance/index usage is already questionable here.

2 years agoAligned admin permission check restriction ignore
Dan Brown [Fri, 13 Jan 2023 22:19:29 +0000 (22:19 +0000)]
Aligned admin permission check restriction ignore

2 years agoUpdated additional relation queries to apply permissions correctly
Dan Brown [Fri, 13 Jan 2023 22:13:31 +0000 (22:13 +0000)]
Updated additional relation queries to apply permissions correctly

2 years agoGot entity relation query permission application working
Dan Brown [Fri, 13 Jan 2023 17:10:20 +0000 (17:10 +0000)]
Got entity relation query permission application working

May be issues at points of use though, Added todo for this in code.
Also added extra indexes to collapsed table for better query
performance.

2 years agoSplit out 'restrictEntityQuery' function components
Dan Brown [Fri, 13 Jan 2023 16:07:36 +0000 (16:07 +0000)]
Split out 'restrictEntityQuery' function components

Also fixed search query issue with abiguous column

2 years agoReworked userCan permission check to follow defined logic.
Dan Brown [Fri, 23 Dec 2022 21:07:49 +0000 (21:07 +0000)]
Reworked userCan permission check to follow defined logic.

Got all current scenario tests passing.
Also fixes own permission which was using the wrong field.

2 years agoFixed collapsed perm. gen for book sub-items.
Dan Brown [Fri, 23 Dec 2022 13:56:22 +0000 (13:56 +0000)]
Fixed collapsed perm. gen for book sub-items.

Also converted the existing "JointPermission" usage to the new
collapsed permission system.

2 years agoCreated big scary query to apply permissions via new format
Dan Brown [Thu, 22 Dec 2022 20:32:06 +0000 (20:32 +0000)]
Created big scary query to apply permissions via new format

2 years agoStarted new permission-caching/querying model
Dan Brown [Thu, 22 Dec 2022 15:09:17 +0000 (15:09 +0000)]
Started new permission-caching/querying model

2 years agoAdded additional case thats known to currently fail
Dan Brown [Wed, 21 Dec 2022 17:00:05 +0000 (17:00 +0000)]
Added additional case thats known to currently fail

Also removed so no-longer-relevant todo/comments.

2 years agoAdded more inter-method permissions test cases
Dan Brown [Tue, 20 Dec 2022 19:10:09 +0000 (19:10 +0000)]
Added more inter-method permissions test cases

2 years agoAdded entity user permission scenarios
Dan Brown [Tue, 20 Dec 2022 15:50:41 +0000 (15:50 +0000)]
Added entity user permission scenarios

Also added definitions for general expected behaviour to readme doc, and
added some entity role inherit scenarios to check they meet expectations.
Currently failing role test but not an issue with test, needs fixing to
app logic.

2 years agoAdded a bunch of role content permissions
Dan Brown [Sat, 17 Dec 2022 19:46:48 +0000 (19:46 +0000)]
Added a bunch of role content permissions

2 years agoAdded additional entity_role_permission scenario tests
Dan Brown [Sat, 17 Dec 2022 15:26:54 +0000 (15:26 +0000)]
Added additional entity_role_permission scenario tests

2 years agoCreate additional test helper classes
Dan Brown [Thu, 15 Dec 2022 12:29:10 +0000 (12:29 +0000)]
Create additional test helper classes

Following recent similar actions done for entities.
Required at this stage to provider better & cleaner helpers
for common user and permission actions to built out permission testing.

2 years agoStarted more formal permission test case definitions
Dan Brown [Thu, 15 Dec 2022 11:22:53 +0000 (11:22 +0000)]
Started more formal permission test case definitions

2 years agoStarted aligning permission behaviour across application methods
Dan Brown [Wed, 14 Dec 2022 18:14:01 +0000 (18:14 +0000)]
Started aligning permission behaviour across application methods

2 years agoAdded joint_user_permissions handling to query system
Dan Brown [Sun, 11 Dec 2022 22:53:46 +0000 (22:53 +0000)]
Added joint_user_permissions handling to query system

Some issues exist to resolve though, not in final state.

2 years agoAdded, and built perm. gen for, joint_user_permissions table
Dan Brown [Sun, 11 Dec 2022 14:51:53 +0000 (14:51 +0000)]
Added, and built perm. gen for, joint_user_permissions table

2 years agoImproved user-permissions adding ux
Dan Brown [Sat, 10 Dec 2022 14:48:19 +0000 (14:48 +0000)]
Improved user-permissions adding ux

- Reset input after user selection.
- Corrected permission row title text for user rows.

2 years agoAdded users to permission form interface
Dan Brown [Sat, 10 Dec 2022 14:37:18 +0000 (14:37 +0000)]
Added users to permission form interface

Also updated non-joint permission handling to support user permissions.

2 years agoAligned logic to entity_permission role_id usage change
Dan Brown [Wed, 7 Dec 2022 22:07:03 +0000 (22:07 +0000)]
Aligned logic to entity_permission role_id usage change

Now idenitifies fallback using role_id and user_id = null.
Lays some foundations for handling user_id.

2 years agoUpdated entity_permissions table for user perms.
Dan Brown [Wed, 7 Dec 2022 14:57:23 +0000 (14:57 +0000)]
Updated entity_permissions table for user perms.

As start of user permissions work

2 years agoUpdated locale list to align with lang folders
Dan Brown [Wed, 30 Nov 2022 12:13:50 +0000 (12:13 +0000)]
Updated locale list to align with lang folders

2 years agoUpdated translator attribution before v22.11 release
Dan Brown [Wed, 30 Nov 2022 12:02:10 +0000 (12:02 +0000)]
Updated translator attribution before v22.11 release

2 years agoNew Crowdin updates (#3828)
Dan Brown [Wed, 30 Nov 2022 12:01:19 +0000 (12:01 +0000)]
New Crowdin updates (#3828)

2 years agoConverted md settings to localstorage, added preview resize
Dan Brown [Mon, 28 Nov 2022 14:08:20 +0000 (14:08 +0000)]
Converted md settings to localstorage, added preview resize

2 years agoMerge pull request #3878 from BookStackApp/dark_style_cleanup
Dan Brown [Mon, 28 Nov 2022 12:42:16 +0000 (12:42 +0000)]
Merge pull request #3878 from BookStackApp/dark_style_cleanup

Cleaned up dark mode styles inc. setting browser color scheme

2 years agoCleaned up dark mode styles inc. setting browser color scheme 3878/head
Dan Brown [Mon, 28 Nov 2022 12:38:30 +0000 (12:38 +0000)]
Cleaned up dark mode styles inc. setting browser color scheme

Forces browser colorscheme based on BookStack color scheme, via
'color-scheme' css property.
Sets proper dark mode colors for some previously missed areas like
templates and attachment control buttons.
Also fixed search bar icon position for some search inputs.

2 years agoMerge pull request #3875 from BookStackApp/md_editor_updates
Dan Brown [Mon, 28 Nov 2022 12:21:33 +0000 (12:21 +0000)]
Merge pull request #3875 from BookStackApp/md_editor_updates

Markdown Editor Updates

2 years agoAdded test to preference boolean endpoint 3875/head
Dan Brown [Mon, 28 Nov 2022 12:17:22 +0000 (12:17 +0000)]
Added test to preference boolean endpoint

2 years agoConnected md editor settings to logic for functionality
Dan Brown [Mon, 28 Nov 2022 12:12:36 +0000 (12:12 +0000)]
Connected md editor settings to logic for functionality

2 years agoAdded md editor ui dropdown options & their back-end storage
Dan Brown [Sun, 27 Nov 2022 20:30:14 +0000 (20:30 +0000)]
Added md editor ui dropdown options & their back-end storage

Still need to perform actual in-editor functionality for those controls.

2 years agoTightened existing markdown editor styles
Dan Brown [Sun, 27 Nov 2022 19:52:10 +0000 (19:52 +0000)]
Tightened existing markdown editor styles

2 years agoAdded callout cycling in markdown editor via shortcut
Dan Brown [Sat, 26 Nov 2022 23:18:51 +0000 (23:18 +0000)]
Added callout cycling in markdown editor via shortcut

2 years agoFixed md editor refactoring issues after manual test
Dan Brown [Sat, 26 Nov 2022 21:33:39 +0000 (21:33 +0000)]
Fixed md editor refactoring issues after manual test

Testing was a full manual feature test of each piece of supported logic
defined in the code.

2 years agoRefactored markdown editor logic
Dan Brown [Sat, 26 Nov 2022 16:43:28 +0000 (16:43 +0000)]
Refactored markdown editor logic

Split out the markdown editor logic into seperate components to provide
a more orgranised heirachy with feature-specific files.

2 years agoFixed tests to align with recent changes, Updated php deps
Dan Brown [Wed, 23 Nov 2022 12:07:46 +0000 (12:07 +0000)]
Fixed tests to align with recent changes, Updated php deps

2 years agoFixed OIDC handling when no JWKS 'use' prop exists
Dan Brown [Wed, 23 Nov 2022 11:50:59 +0000 (11:50 +0000)]
Fixed OIDC handling when no JWKS 'use' prop exists

Now assume, based on OIDC discovery spec, that keys without 'use' are
'sig' keys. Should not affect existing use-cases since existance of such
keys would have throw exceptions in prev. versions of bookstack.

For #3869

2 years agoMerge branch 'development' of github.com:BookStackApp/BookStack into development
Dan Brown [Wed, 23 Nov 2022 00:13:02 +0000 (00:13 +0000)]
Merge branch 'development' of github.com:BookStackApp/BookStack into development

2 years agoUpdated global search component to new format
Dan Brown [Wed, 23 Nov 2022 00:12:41 +0000 (00:12 +0000)]
Updated global search component to new format

2 years agoMerge branch 'search_preview' into development
Dan Brown [Wed, 23 Nov 2022 00:10:21 +0000 (00:10 +0000)]
Merge branch 'search_preview' into development

2 years agoAdjusted global search preview for dark mode 3850/head
Dan Brown [Wed, 23 Nov 2022 00:05:24 +0000 (00:05 +0000)]
Adjusted global search preview for dark mode

2 years agoExtracted keyboard nav. from dropdowns to share w/ search
Dan Brown [Mon, 21 Nov 2022 17:35:19 +0000 (17:35 +0000)]
Extracted keyboard nav. from dropdowns to share w/ search

2 years agoAdded new endpoint for search suggestions
Dan Brown [Mon, 21 Nov 2022 10:29:12 +0000 (10:29 +0000)]
Added new endpoint for search suggestions

2 years agoMerge pull request #3852 from BookStackApp/php82
Dan Brown [Sun, 20 Nov 2022 22:21:52 +0000 (22:21 +0000)]
Merge pull request #3852 from BookStackApp/php82

PHP8.2 Support

2 years agoAdded global search input debounce and loading indicator
Dan Brown [Sun, 20 Nov 2022 22:20:31 +0000 (22:20 +0000)]
Added global search input debounce and loading indicator

2 years agoReplaced JS logic with CSS focus-within logic
Dan Brown [Sun, 20 Nov 2022 21:53:53 +0000 (21:53 +0000)]
Replaced JS logic with CSS focus-within logic

2 years agoFixed input styles in search preview mode, added animation
Dan Brown [Sun, 20 Nov 2022 21:50:59 +0000 (21:50 +0000)]
Fixed input styles in search preview mode, added animation

Also added JS handlers for hiding the suggestions

2 years agoMerge pull request #3853 from BookStackApp/component_refactor
Dan Brown [Wed, 16 Nov 2022 16:05:57 +0000 (16:05 +0000)]
Merge pull request #3853 from BookStackApp/component_refactor

Started refactor and alignment of JS component system

2 years agoUpdated js dev docs with latest component changes 3853/head
Dan Brown [Wed, 16 Nov 2022 16:02:31 +0000 (16:02 +0000)]
Updated js dev docs with latest component changes

2 years agoReplaced el.components mapping with component service weakmap
Dan Brown [Wed, 16 Nov 2022 15:46:41 +0000 (15:46 +0000)]
Replaced el.components mapping with component service weakmap

Old system was hard to track in terms of usage and it's application of
'components' properties directly to elements was shoddy.
This routes usage via the components service, with element-specific
component usage tracked via a local weakmap.
Updated existing found usages to use the new system.

2 years agoRemoved use of image-manager/entity-selector window globals
Dan Brown [Wed, 16 Nov 2022 15:21:22 +0000 (15:21 +0000)]
Removed use of image-manager/entity-selector window globals

2 years agoFinished updating remainder of JS components to new system
Dan Brown [Wed, 16 Nov 2022 13:04:22 +0000 (13:04 +0000)]
Finished updating remainder of JS components to new system

2 years agoUpdated a whole load more js components
Dan Brown [Tue, 15 Nov 2022 16:04:46 +0000 (16:04 +0000)]
Updated a whole load more js components

2 years agoUpdated another set of components
Dan Brown [Tue, 15 Nov 2022 12:44:57 +0000 (12:44 +0000)]
Updated another set of components

2 years agoUpdated a batch of JS components
Dan Brown [Tue, 15 Nov 2022 11:24:31 +0000 (11:24 +0000)]
Updated a batch of JS components

2 years agoStarted refactor and alignment of component system
Dan Brown [Mon, 14 Nov 2022 23:19:02 +0000 (23:19 +0000)]
Started refactor and alignment of component system

- Updates old components to newer format, removes legacy component
support.
- Makes component registration easier and less duplicated.
- Adds base component class to extend for better editor support.
- Aligns global window exposure usage and aligns with other service
  names.

2 years agoAdded php8.2 to GH action checks 3852/head
Dan Brown [Mon, 14 Nov 2022 18:26:01 +0000 (18:26 +0000)]
Added php8.2 to GH action checks

2 years agoStarted on a live-preview on global search input
Dan Brown [Mon, 14 Nov 2022 10:24:14 +0000 (10:24 +0000)]
Started on a live-preview on global search input

2 years agoUpdated email confirmation flow so confirmation is done via POST
Dan Brown [Sat, 12 Nov 2022 15:10:14 +0000 (15:10 +0000)]
Updated email confirmation flow so confirmation is done via POST

To avoid non-user GET requests (Such as those from email scanners)
auto-triggering the confirm submission. Made auto-submit the form via
JavaScript in this extra added step with user-link backup to keep
existing user flow experience.

Closes #3797

2 years agoMerge pull request #3848 from BookStackApp/auth_message_partials
Dan Brown [Sat, 12 Nov 2022 09:03:59 +0000 (09:03 +0000)]
Merge pull request #3848 from BookStackApp/auth_message_partials

Added login/register message partials for easier use via theme system

2 years agoAdded login/register message partials for easier use via theme system 3848/head
Dan Brown [Sat, 12 Nov 2022 09:02:33 +0000 (09:02 +0000)]
Added login/register message partials for easier use via theme system

Related to #608

2 years agoAdded swift support to code blocks and editor
Dan Brown [Sat, 12 Nov 2022 08:44:25 +0000 (08:44 +0000)]
Added swift support to code blocks and editor

Closes #3847

2 years agoFixed app logo visibility with secure_restricted images
Dan Brown [Thu, 10 Nov 2022 14:15:59 +0000 (14:15 +0000)]
Fixed app logo visibility with secure_restricted images

Includes test to cover.
For #3827

2 years agoAdded test to cover books perms. gen with deleted chapter
Dan Brown [Thu, 10 Nov 2022 13:48:17 +0000 (13:48 +0000)]
Added test to cover books perms. gen with deleted chapter

Closes #3796

2 years agoAdded dart support to code blocks/editing
Dan Brown [Thu, 10 Nov 2022 13:38:56 +0000 (13:38 +0000)]
Added dart support to code blocks/editing

For #3808

2 years agoExtracted hardcoded english text to language files
Dan Brown [Thu, 10 Nov 2022 13:30:48 +0000 (13:30 +0000)]
Extracted hardcoded english text to language files

Closes #3822

2 years agoMerge pull request #3830 from BookStackApp/shortcuts
Dan Brown [Thu, 10 Nov 2022 10:32:56 +0000 (10:32 +0000)]
Merge pull request #3830 from BookStackApp/shortcuts

User interface shortcuts system

2 years agoExtracted shortcut text to language files 3830/head
Dan Brown [Thu, 10 Nov 2022 10:25:28 +0000 (10:25 +0000)]
Extracted shortcut text to language files

2 years agoAligned user preference endpoints in style and behaviour
Dan Brown [Wed, 9 Nov 2022 19:30:08 +0000 (19:30 +0000)]
Aligned user preference endpoints in style and behaviour

Changes their endpoints and remove the user id from the URLs.
Simplifies list changes to share a single endpoint, which aligns it to
the behaviour of the existing sort preference endpoint.
Also added test to ensure user preferences are deleted on user delete.

2 years agoAdded tests to cover shortcut endpoints
Dan Brown [Wed, 9 Nov 2022 18:42:54 +0000 (18:42 +0000)]
Added tests to cover shortcut endpoints

2 years agoAdded shortcut input controls to make custom shortcuts work
Dan Brown [Wed, 9 Nov 2022 14:40:44 +0000 (14:40 +0000)]
Added shortcut input controls to make custom shortcuts work

2 years agoStarted interface user shortcut form interface
Dan Brown [Tue, 8 Nov 2022 21:17:45 +0000 (21:17 +0000)]
Started interface user shortcut form interface

Built controller actions and initual UI.
Still needs JS logic for shortcut input handling.

2 years agoImproved shortcut overlay with related action highlighting
Dan Brown [Sat, 5 Nov 2022 13:57:22 +0000 (13:57 +0000)]
Improved shortcut overlay with related action highlighting

2 years agoDistributed shortcut actions to common ui elements
Dan Brown [Sat, 5 Nov 2022 13:39:17 +0000 (13:39 +0000)]
Distributed shortcut actions to common ui elements

2 years agoStarted implementation of UI shortcuts system
Dan Brown [Fri, 4 Nov 2022 15:20:19 +0000 (15:20 +0000)]
Started implementation of UI shortcuts system

2 years agoMerge pull request #3821 from BookStackApp/list_reworks
Dan Brown [Thu, 3 Nov 2022 14:52:40 +0000 (14:52 +0000)]
Merge pull request #3821 from BookStackApp/list_reworks

Revision of item list views

2 years agoAddressed additional unsupported array spread operation 3821/head
Dan Brown [Thu, 3 Nov 2022 14:40:01 +0000 (14:40 +0000)]
Addressed additional unsupported array spread operation

2 years agoFixed use of array unpacking syntax
Dan Brown [Thu, 3 Nov 2022 14:33:23 +0000 (14:33 +0000)]
Fixed use of array unpacking syntax

Since it was using keyed arrays, unpacking is only supported in php8.1+

2 years agoFixed phpstan static usage warning, updated ci flows
Dan Brown [Thu, 3 Nov 2022 14:14:22 +0000 (14:14 +0000)]
Fixed phpstan static usage warning, updated ci flows

CI flow updates to follow deprecation warnings

2 years agoUpdated role permission table to responsive format
Dan Brown [Thu, 3 Nov 2022 13:28:07 +0000 (13:28 +0000)]
Updated role permission table to responsive format

2 years agoUpdated search term lists to flex layouts
Dan Brown [Thu, 3 Nov 2022 12:49:05 +0000 (12:49 +0000)]
Updated search term lists to flex layouts

2 years agoMerge branch 'v22-10' into development
Dan Brown [Wed, 2 Nov 2022 15:22:53 +0000 (15:22 +0000)]
Merge branch 'v22-10' into development

2 years agoUpdated translator attribution before release v22.10.2
Dan Brown [Wed, 2 Nov 2022 15:19:13 +0000 (15:19 +0000)]
Updated translator attribution before release v22.10.2

2 years agoMerged and squashed l10n_development into v22-10
Dan Brown [Wed, 2 Nov 2022 15:17:54 +0000 (15:17 +0000)]
Merged and squashed l10n_development into v22-10

2 years agoUpdated tests to align with recent list changes
Dan Brown [Tue, 1 Nov 2022 14:53:36 +0000 (14:53 +0000)]
Updated tests to align with recent list changes

2 years agoRevised revision list to responsive layout
Dan Brown [Mon, 31 Oct 2022 21:26:31 +0000 (21:26 +0000)]
Revised revision list to responsive layout

2 years agoUpdated recycle bin list to new responsive layout
Dan Brown [Mon, 31 Oct 2022 16:45:32 +0000 (16:45 +0000)]
Updated recycle bin list to new responsive layout

2 years agoUpdated tags list to new responsive format
Dan Brown [Mon, 31 Oct 2022 11:40:28 +0000 (11:40 +0000)]
Updated tags list to new responsive format

2 years agoTweaked list spacings a little to align paddings
Dan Brown [Sun, 30 Oct 2022 21:06:42 +0000 (21:06 +0000)]
Tweaked list spacings a little to align paddings

2 years agoRemoved addition detail spacing in audit list
Dan Brown [Sun, 30 Oct 2022 20:29:21 +0000 (20:29 +0000)]
Removed addition detail spacing in audit list

2 years agoAdjusted audit log row spacing a tad
Dan Brown [Sun, 30 Oct 2022 20:27:41 +0000 (20:27 +0000)]
Adjusted audit log row spacing a tad

2 years agoRevised audit log list to new responsive format
Dan Brown [Sun, 30 Oct 2022 20:24:08 +0000 (20:24 +0000)]
Revised audit log list to new responsive format

2 years agoUpdated API tokens list to new responsive format
Dan Brown [Sun, 30 Oct 2022 15:37:52 +0000 (15:37 +0000)]
Updated API tokens list to new responsive format

2 years agoSplit out user controller preference methods to new controller
Dan Brown [Sun, 30 Oct 2022 15:25:02 +0000 (15:25 +0000)]
Split out user controller preference methods to new controller

2 years agoRefactored common list handling operations to new class
Dan Brown [Sun, 30 Oct 2022 15:16:06 +0000 (15:16 +0000)]
Refactored common list handling operations to new class

2 years agoRevised webhooks list to new format
Dan Brown [Sun, 30 Oct 2022 12:02:06 +0000 (12:02 +0000)]
Revised webhooks list to new format

Also aligned query naming to start with model in use.
Also added created/updated sort options to roles.

2 years agoRevised role index list to align with user list
Dan Brown [Sat, 29 Oct 2022 19:52:17 +0000 (20:52 +0100)]
Revised role index list to align with user list