Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.164
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.165
Choose a head ref
  • 13 commits
  • 23 files changed
  • 2 contributors

Commits on May 28, 2023

  1. Fix incorrect count of fields passed to tuple deserialization methods

    This count should mean the number of fields expected in the serialized form,
    so if some fields are skipped, they shouldn't be counted
    
    Methods affected:
    - Deserializer::deserialize_tuple
    - Deserializer::deserialize_tuple_struct
    - VariantAccess::tuple_variant
    Mingun committed May 28, 2023
    Configuration menu
    Copy the full SHA
    2c1f62d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge pull request #2466 from Mingun/fix-de-count-of-field

    Fix incorrect count of fields passed to tuple deserialization methods
    dtolnay authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8a4dfa7 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    6d0b43a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0993880 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20a48c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. Configuration menu
    Copy the full SHA
    c0ba323 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    b053b4f View commit details
    Browse the repository at this point in the history
  2. Resolve explicit_iter_loop pedantic clippy lint

        error: it is more concise to loop over references to containers instead of using explicit iteration methods
            --> serde/src/private/de.rs:2761:22
             |
        2761 |         for entry in self.0.iter_mut() {
             |                      ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut *self.0`
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
             = note: `-D clippy::explicit-iter-loop` implied by `-D clippy::pedantic`
    
        error: it is more concise to loop over references to containers instead of using explicit iteration methods
           --> serde_derive/src/internals/check.rs:202:20
            |
        202 |     for variant in variants.iter() {
            |                    ^^^^^^^^^^^^^^^ help: to write this more concisely, try: `variants`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
            = note: `-D clippy::explicit-iter-loop` implied by `-D clippy::pedantic`
    
        error: it is more concise to loop over references to containers instead of using explicit iteration methods
           --> serde_derive/src/bound.rs:262:28
            |
        262 |             for variant in variants.iter() {
            |                            ^^^^^^^^^^^^^^^ help: to write this more concisely, try: `variants`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
    dtolnay committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6b4e755 View commit details
    Browse the repository at this point in the history
  3. Resolve redundant_closure_call clippy lint

        error: try not to call a closure in the expression where it is declared
            --> serde/src/de/impls.rs:1590:76
             |
        1590 |                       <(_, u16)>::deserialize(deserializer).map(|(ip, port)| $new(ip, port))
             |                                                                              ^^^^^^^^^^^^^^
        ...
        1620 | / parse_socket_impl!("IPv6 socket address" net::SocketAddrV6, |ip, port| net::SocketAddrV6::new(
        1621 | |     ip, port, 0, 0
        1622 | | ));
             | |__- in this macro invocation
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call
             = note: `-D clippy::redundant-closure-call` implied by `-D clippy::all`
             = note: this error originates in the macro `parse_socket_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    81ac54b View commit details
    Browse the repository at this point in the history
  4. Resolve useless_conversion clippy lint in test

        error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
           --> test_suite/tests/test_de.rs:202:12
            |
        202 |     .chain(vec![Token::MapEnd].into_iter())
            |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![Token::MapEnd]`
            |
        note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
           --> /home/david/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:522:12
            |
        522 |         U: IntoIterator<Item = Self::Item>,
            |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
            = note: `-D clippy::useless-conversion` implied by `-D clippy::all`
    dtolnay committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6a9a21f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    015e397 View commit details
    Browse the repository at this point in the history
  6. Fix -Zminimal-versions build

    dtolnay committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0289d31 View commit details
    Browse the repository at this point in the history
  7. Release 1.0.165

    dtolnay committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dcbc3e0 View commit details
    Browse the repository at this point in the history
Loading