-
-
Notifications
You must be signed in to change notification settings - Fork 845
Comparing changes
Open a pull request
base repository: serde-rs/serde
base: v1.0.164
head repository: serde-rs/serde
compare: v1.0.165
- 13 commits
- 23 files changed
- 2 contributors
Commits on May 28, 2023
-
Fix incorrect count of fields passed to tuple deserialization methods
This count should mean the number of fields expected in the serialized form, so if some fields are skipped, they shouldn't be counted Methods affected: - Deserializer::deserialize_tuple - Deserializer::deserialize_tuple_struct - VariantAccess::tuple_variant
Configuration menu - View commit details
-
Copy full SHA for 2c1f62d - Browse repository at this point
Copy the full SHA 2c1f62dView commit details
Commits on Jun 8, 2023
-
Merge pull request #2466 from Mingun/fix-de-count-of-field
Fix incorrect count of fields passed to tuple deserialization methods
Configuration menu - View commit details
-
Copy full SHA for 8a4dfa7 - Browse repository at this point
Copy the full SHA 8a4dfa7View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d0b43a - Browse repository at this point
Copy the full SHA 6d0b43aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0993880 - Browse repository at this point
Copy the full SHA 0993880View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a48c9 - Browse repository at this point
Copy the full SHA 20a48c9View commit details
Commits on Jun 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c0ba323 - Browse repository at this point
Copy the full SHA c0ba323View commit details
Commits on Jul 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b053b4f - Browse repository at this point
Copy the full SHA b053b4fView commit details -
Resolve explicit_iter_loop pedantic clippy lint
error: it is more concise to loop over references to containers instead of using explicit iteration methods --> serde/src/private/de.rs:2761:22 | 2761 | for entry in self.0.iter_mut() { | ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut *self.0` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop = note: `-D clippy::explicit-iter-loop` implied by `-D clippy::pedantic` error: it is more concise to loop over references to containers instead of using explicit iteration methods --> serde_derive/src/internals/check.rs:202:20 | 202 | for variant in variants.iter() { | ^^^^^^^^^^^^^^^ help: to write this more concisely, try: `variants` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop = note: `-D clippy::explicit-iter-loop` implied by `-D clippy::pedantic` error: it is more concise to loop over references to containers instead of using explicit iteration methods --> serde_derive/src/bound.rs:262:28 | 262 | for variant in variants.iter() { | ^^^^^^^^^^^^^^^ help: to write this more concisely, try: `variants` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
Configuration menu - View commit details
-
Copy full SHA for 6b4e755 - Browse repository at this point
Copy the full SHA 6b4e755View commit details -
Resolve redundant_closure_call clippy lint
error: try not to call a closure in the expression where it is declared --> serde/src/de/impls.rs:1590:76 | 1590 | <(_, u16)>::deserialize(deserializer).map(|(ip, port)| $new(ip, port)) | ^^^^^^^^^^^^^^ ... 1620 | / parse_socket_impl!("IPv6 socket address" net::SocketAddrV6, |ip, port| net::SocketAddrV6::new( 1621 | | ip, port, 0, 0 1622 | | )); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call = note: `-D clippy::redundant-closure-call` implied by `-D clippy::all` = note: this error originates in the macro `parse_socket_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
Configuration menu - View commit details
-
Copy full SHA for 81ac54b - Browse repository at this point
Copy the full SHA 81ac54bView commit details -
Resolve useless_conversion clippy lint in test
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> test_suite/tests/test_de.rs:202:12 | 202 | .chain(vec![Token::MapEnd].into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![Token::MapEnd]` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /home/david/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:522:12 | 522 | U: IntoIterator<Item = Self::Item>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D clippy::all`
Configuration menu - View commit details
-
Copy full SHA for 6a9a21f - Browse repository at this point
Copy the full SHA 6a9a21fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 015e397 - Browse repository at this point
Copy the full SHA 015e397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0289d31 - Browse repository at this point
Copy the full SHA 0289d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcbc3e0 - Browse repository at this point
Copy the full SHA dcbc3e0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.164...v1.0.165