Changeset 166184 in webkit

Timestamp:

Mar 24, 2014, 12:25:32 PM (11 years ago)

Author:

[email protected]

Message:

Add support for thread QoS
​https://bugs.webkit.org/show_bug.cgi?id=130688

Reviewed by Andreas Kling.

Source/JavaScriptCore:

• heap/BlockAllocator.cpp:

(JSC::BlockAllocator::blockFreeingThreadStartFunc):

• block freeing is a utility activity.

Source/WTF:

• wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::runScavengerThread):

• block freeing is a utility activity.

• wtf/Threading.h:
  • declaration.
• wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):

• default to interactive.

(WTF::setCurrentThreadQOSUtility):

• implementation.

• wtf/ThreadingWin.cpp:

(WTF::setCurrentThreadQOSUtility):

• no-op implementation.

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/heap/BlockAllocator.cpp (modified) (2 diffs)
• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/FastMalloc.cpp (modified) (2 diffs)
• WTF/wtf/Threading.h (modified) (2 diffs)
• WTF/wtf/ThreadingPthreads.cpp (modified) (2 diffs)
• WTF/wtf/ThreadingWin.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-03-24  Gavin Barraclough  <[email protected]>
+
+        Add support for thread QoS
+        https://bugs.webkit.org/show_bug.cgi?id=130688
+
+        Reviewed by Andreas Kling.
+
+        * heap/BlockAllocator.cpp:
+        (JSC::BlockAllocator::blockFreeingThreadStartFunc):
+            - block freeing is a utility activity.
+
 2014-03-24  Filip Pizlo  <[email protected]>
 

trunk/Source/JavaScriptCore/heap/BlockAllocator.cpp

@@ -33 +33 @@
 #include "WeakBlock.h"
 #include <wtf/CurrentTime.h>
+#include <wtf/Threading.h>
 
 namespace JSC {
@@ -118 +119 @@
 void BlockAllocator::blockFreeingThreadStartFunc(void* blockAllocator)
 {
+    setCurrentThreadQOSUtility();
     static_cast<BlockAllocator*>(blockAllocator)->blockFreeingThreadMain();
 }

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2014-03-24  Gavin Barraclough  <[email protected]>
+
+        Add support for thread QoS
+        https://bugs.webkit.org/show_bug.cgi?id=130688
+
+        Reviewed by Andreas Kling.
+
+        * wtf/FastMalloc.cpp:
+        (WTF::TCMalloc_PageHeap::runScavengerThread):
+            - block freeing is a utility activity.
+        * wtf/Threading.h:
+            - declaration.
+        * wtf/ThreadingPthreads.cpp:
+        (WTF::createThreadInternal):
+            - default to interactive.
+        (WTF::setCurrentThreadQOSUtility):
+            - implementation.
+        * wtf/ThreadingWin.cpp:
+        (WTF::setCurrentThreadQOSUtility):
+            - no-op implementation.
+
 2014-03-23  Hyowon Kim  <[email protected]>
 

trunk/Source/WTF/wtf/FastMalloc.cpp

@@ -80 +80 @@
 #include "Assertions.h"
 #include "CurrentTime.h"
+#include "Threading.h"
 
 #include <limits>
@@ -2059 +2060 @@
 void* TCMalloc_PageHeap::runScavengerThread(void* context)
 {
+    setCurrentThreadQOSUtility();
+
     static_cast<TCMalloc_PageHeap*>(context)->scavengerThread();
 #if (COMPILER(MSVC) || COMPILER(SUNCC))

trunk/Source/WTF/wtf/Threading.h

@@ -90 +90 @@
 
 WTF_EXPORT_PRIVATE ThreadIdentifier currentThread();
+WTF_EXPORT_PRIVATE void setCurrentThreadQOSUtility();
 WTF_EXPORT_PRIVATE void changeThreadPriority(ThreadIdentifier, int);
 WTF_EXPORT_PRIVATE int waitForThreadCompletion(ThreadIdentifier);
@@ -100 +101 @@
 using WTF::currentThread;
 using WTF::changeThreadPriority;
+using WTF::setCurrentThreadQOSUtility;
 using WTF::detachThread;
 using WTF::waitForThreadCompletion;

trunk/Source/WTF/wtf/ThreadingPthreads.cpp

@@ -174 +174 @@
     auto invocation = std::make_unique<ThreadFunctionInvocation>(entryPoint, data);
     pthread_t threadHandle;
-    if (pthread_create(&threadHandle, 0, wtfThreadEntryPoint, invocation.get())) {
+    pthread_attr_t attr;
+    pthread_attr_init(&attr);
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+    pthread_attr_set_qos_class_np(&attr, QOS_CLASS_USER_INTERACTIVE, 0);
+#endif
+    int error = pthread_create(&threadHandle, &attr, wtfThreadEntryPoint, invocation.get());
+    pthread_attr_destroy(&attr);
+
+    if (error) {
         LOG_ERROR("Failed to create pthread at entry point %p with data %p", wtfThreadEntryPoint, invocation.get());
         return 0;
@@ -226 +234 @@
     pthread_setschedparam(pthreadHandle, policy, &param);
 }
-    
+
+void setCurrentThreadQOSUtility()
+{
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+    pthread_set_qos_class_np(pthread_self(), QOS_CLASS_UTILITY, 0);
+#endif
+}
+
 int waitForThreadCompletion(ThreadIdentifier threadID)
 {

trunk/Source/WTF/wtf/ThreadingWin.cpp

@@ -256 +256 @@
 
     SetThreadPriority(threadHandle, THREAD_PRIORITY_NORMAL + delta);
+}
+
+void setCurrentThreadQOSUtility()
+{
 }