Changeset 286776 in webkit

Timestamp:

Dec 9, 2021, 6:03:45 AM (3 years ago)

Author:

Manuel Rego Casasnovas

Message:

[selectors] Match :focus-visible on <select> elements
​https://bugs.webkit.org/show_bug.cgi?id=233924

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/forms/select-listbox-focusring.html

• dom/Element.cpp:

(WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):

LayoutTests:

• fast/forms/select-listbox-focusring-expected.html: Added.
• fast/forms/select-listbox-focusring.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/select-listbox-focusring-expected.html (added)
• LayoutTests/fast/forms/select-listbox-focusring.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-12-09  Manuel Rego Casasnovas  <[email protected]>
+
+        [selectors] Match :focus-visible on <select> elements
+        https://bugs.webkit.org/show_bug.cgi?id=233924
+
+        Reviewed by Antti Koivisto.
+
+        * fast/forms/select-listbox-focusring-expected.html: Added.
+        * fast/forms/select-listbox-focusring.html: Added.
+
 2021-12-08  Patrick Griffis  <[email protected]>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-09  Manuel Rego Casasnovas  <[email protected]>
+
+        [selectors] Match :focus-visible on <select> elements
+        https://bugs.webkit.org/show_bug.cgi?id=233924
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/forms/select-listbox-focusring.html
+
+        * dom/Element.cpp:
+        (WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):
+
 2021-12-09  Antti Koivisto  <[email protected]>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -808 +808 @@
 static bool shouldAlwaysHaveFocusVisibleWhenFocused(const Element& element)
 {
-    return element.isTextField() || element.isContentEditable();
+    return element.isTextField() || element.isContentEditable() || is<HTMLSelectElement>(element);
 }