| From: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
|---|---|
| To: | Arthur Zakirov <zaartur(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade fails with non-standard ACL |
| Date: | 2020-04-06 13:49:31 |
| Message-ID: | [email protected] |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
New version of the patch is attached. I fixed several issues in the
check_for_changed_signatures().
Now it passes check without "test_rename_catalog_objects" and fails
(generates script) with it. Test script pg_upgrade_ACL_test.sh
demonstrates this.
The only known issue left is the usage of pg_identify_object(), though I
don't see a problem here with object types that this patch involves.
As I updated the code, I will leave this patch in Need Review.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade_ACL_test.sh | application/x-shellscript | 3.1 KB |
| pg_upgrade_ACL_check_v7.patch | text/x-patch | 13.8 KB |
| test_rename_catalog_objects | text/plain | 49.0 KB |
| test_add_acl_to_catalog_objects.sql | application/sql | 436 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-06 14:09:12 | Re: d25ea01275 and partitionwise join |
| Previous Message | Andres Freund | 2020-04-06 13:39:59 | Re: Improving connection scalability: GetSnapshotData() |