| Lists: | pgsql-hackers |
|---|
| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | PG docs - Sequence CYCLE clause |
| Date: | 2024-08-13 05:46:36 |
| Message-ID: | CAHut+PtqwZwPfGq62xq2614_ce2ejDmbB9CfP+a1azxpneFRBQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi hackers.
While reviewing another thread I had cause to be looking more
carefully at the SEQUENCE documentation.
I found it curious that, unlike other clauses, the syntax of the CYCLE
clause was not displayed on a line by itself.
I have changed that, and at the same time I have moved the CYCLE
syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
which IMO is where it naturally belongs.
Please see the attached patch.
Thoughts?
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| docs_sequence_cycle.diff | application/octet-stream | 7.9 KB |
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PG docs - Sequence CYCLE clause |
| Date: | 2024-08-14 11:46:23 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 13.08.24 07:46, Peter Smith wrote:
> While reviewing another thread I had cause to be looking more
> carefully at the SEQUENCE documentation.
>
> I found it curious that, unlike other clauses, the syntax of the CYCLE
> clause was not displayed on a line by itself.
>
> I have changed that, and at the same time I have moved the CYCLE
> syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
> which IMO is where it naturally belongs.
>
> Please see the attached patch.
I agree, it makes a bit more sense with your patches.
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PG docs - Sequence CYCLE clause |
| Date: | 2024-08-20 00:18:15 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 14, 2024 at 01:46:23PM +0200, Peter Eisentraut wrote:
> On 13.08.24 07:46, Peter Smith wrote:
> > While reviewing another thread I had cause to be looking more
> > carefully at the SEQUENCE documentation.
> >
> > I found it curious that, unlike other clauses, the syntax of the CYCLE
> > clause was not displayed on a line by itself.
> >
> > I have changed that, and at the same time I have moved the CYCLE
> > syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
> > which IMO is where it naturally belongs.
> >
> > Please see the attached patch.
>
> I agree, it makes a bit more sense with your patches.
Great, patch applied to master.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PG docs - Sequence CYCLE clause |
| Date: | 2024-08-20 03:05:33 |
| Message-ID: | CAHut+PtJOBkD3Jh-MTYhSsjAZ5RGBQoM6HruX=S9CjujxNnoDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Aug 20, 2024 at 10:18 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> Great, patch applied to master.
>
Thanks for pushing!
======
Kind Regards,
Peter Smith.
Fujitsu Australia