| Lists: | pgsql-hackers |
|---|
| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-05-21 07:38:37 |
| Message-ID: | CALj2ACU4-aNLX=DrUM8F7QDwynJKzYRiqOj_33NhnGbhDs5-kQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
While working on a feature, I noticed that there are unnecessary
includes of "use File::Path qw(rmtree);" in some TAP test files and
also some wrong comments in 019_replslot_limit.pl. Attaching a patch
to fix these.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-unnecessary-includes-and-comments-in-019_repl.patch | application/octet-stream | 2.2 KB |
| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-06 13:05:03 |
| Message-ID: | CACG=ezZJ-hDRSQJjcuT8ZZMyy3mwN0mufC9aWo8kpYEm5VeqSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi!
This is an obvious change, I totally for it. Hope it will be commited soon.
--
Best regards,
Maxim Orlov.
| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-06 13:22:14 |
| Message-ID: | CALT9ZEF-EwaQ8R_7Eay2Vj7500UnHzJBRy7_iGDEEqY_cchqoA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jul 6, 2022 at 5:05 PM Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
> Hi!
>
> This is an obvious change, I totally for it. Hope it will be commited soon.
>
I'm sorry for some nitpicking about changes in the comments:
- The number of WAL segments advanced hasn't changed from 5 to 1, it just
advances as 1+4 as previously. So the original comment is right. I reverted
this in v2.
- wal_segment_size is in bytes so comment "(wal_segment_size * n) MB" is
incorrect. I corrected this to bytes.
PFA v2 of a patch (only comments changed/reverted to original).
Overall I completely agree with Maxim: the patch is good and simple enough
to be RfC.
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-unnecessary-includes-and-comments-in-019_repl.patch | application/octet-stream | 1.9 KB |
| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-06 13:26:38 |
| Message-ID: | CACG=ezYBsbE2nKGOAASmbWQNGktgx=T04tKSFkTkc+=x-WP0LQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
>
> I'm sorry for some nitpicking about changes in the comments:
> - The number of WAL segments advanced hasn't changed from 5 to 1, it just
> advances as 1+4 as previously. So the original comment is right. I reverted
> this in v2.
>
Yeah, it looks even better now.
--
Best regards,
Maxim Orlov.
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-07 01:24:40 |
| Message-ID: | YsY12ONviAiulk/[email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jul 06, 2022 at 04:26:38PM +0300, Maxim Orlov wrote:
> Yeah, it looks even better now.
Especially knowing that the test uses a segment size of 1MB via initdb
to be cheaper. v2 looks fine by itself, so applied.
--
Michael
| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Maxim Orlov <orlovmg(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-07 08:50:00 |
| Message-ID: | CALT9ZEEer67MEpK-Ohf0Kh3jJ6r8Dj=SH3paTfKCC2C0TDK4Qg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
>
> Especially knowing that the test uses a segment size of 1MB via initdb
> to be cheaper. v2 looks fine by itself, so applied.
>
Thanks, Michael!
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>