| Lists: | pgsql-hackers |
|---|
| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Remove dead code generation tools in src/backend/utils/mb/ |
| Date: | 2024-07-29 11:18:40 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
These programs in src/backend/utils/mb/ are unused, and have been unused
and unusable since 2003:
iso.c
win1251.c
win866.c
Attached patch removes them. See commit message for a little more
detailed analysis.
--
Heikki Linnakangas
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-dead-generators-for-cyrillic-encoding-convers.patch | text/x-patch | 6.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove dead code generation tools in src/backend/utils/mb/ |
| Date: | 2024-07-29 14:15:08 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> These programs in src/backend/utils/mb/ are unused, and have been unused
> and unusable since 2003:
> iso.c
> win1251.c
> win866.c
> Attached patch removes them. See commit message for a little more
> detailed analysis.
+1. Seems to have been my oversight in 4c3c8c048d.
regards, tom lane
| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove dead code generation tools in src/backend/utils/mb/ |
| Date: | 2024-07-29 15:00:00 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello Tom and Heikki,
29.07.2024 17:15, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> These programs in src/backend/utils/mb/ are unused, and have been unused
>> and unusable since 2003:
>> iso.c
>> win1251.c
>> win866.c
>> Attached patch removes them. See commit message for a little more
>> detailed analysis.
> +1. Seems to have been my oversight in 4c3c8c048d.
I also wonder whether src/test/locale/ still makes sense; does anyone
run those tests (I could not run a single one on a quick attempt)?
(As far as I can tell, KOI8-R fallen out of mainstream usage in Russia
twenty years ago...)
Best regards,
Alexander
| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove dead code generation tools in src/backend/utils/mb/ |
| Date: | 2024-07-29 15:06:40 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 7/29/24 5:00 PM, Alexander Lakhin wrote:
> I also wonder whether src/test/locale/ still makes sense; does anyone
> run those tests (I could not run a single one on a quick attempt)?
I was actually wondering about those yesterday and they should probably
be removed (or fixed if anyone can see a use for them). As they are
right now they do not seem very useful, especially with the current
selection of locales: de_DE.ISO8859-1, gr_GR.ISO8859-7 and koi8-r.
Andreas
| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Subject: | Re: Remove dead code generation tools in src/backend/utils/mb/ |
| Date: | 2024-07-29 17:41:06 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 29/07/2024 17:15, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> These programs in src/backend/utils/mb/ are unused, and have been unused
>> and unusable since 2003:
>> iso.c
>> win1251.c
>> win866.c
>> Attached patch removes them. See commit message for a little more
>> detailed analysis.
>
> +1. Seems to have been my oversight in 4c3c8c048d.
Removed.
(Aleksander, you forgot to CC the mailing list, but thanks for your
review too.)
--
Heikki Linnakangas
Neon (https://neon.tech)