dbus: do not silently ignore invalid parametersHEADdev

Requesting to stop an application with an unknown id would just result
in the appman-controller exiting with code '0', instead of complaining.

This patch fixes all those cases, where an invalid id parameter or even
a missing installer sub-system would silently be accepted on a DBus
call.

Change-Id: I1ffc8cec970a79c23fde82c7523b2a69519a5583
Pick-to: 6.10
Reviewed-by: Dominik Holland <[email protected]>

2 files changed, 15 insertions, 1 deletions

diff --git a/src/manager-lib/packagemanager.cpp b/src/manager-lib/packagemanager.cpp
index e8d1bfc5..b839f6a4 100644
--- a/src/manager-lib/packagemanager.cpp
+++ b/src/manager-lib/packagemanager.cpp
@@ -682,6 +682,18 @@ bool PackageManager::isReady() const
 }
 
 /*!
+    \qmlproperty bool PackageManager::installationEnabled
+    \readonly
+
+    Defaults to \c true. Only returns \c false, if the installer part of the application manager
+    has been \l{config disable installer}{disabled at compile time}.
+*/
+bool PackageManager::installationEnabled() const
+{
+    return d->enableInstaller;
+}
+
+/*!
     \qmlproperty bool PackageManager::developmentMode
     \readonly
 
@@ -699,7 +711,7 @@ void PackageManager::setDevelopmentMode(bool enable)
 }
 
 /*!
-    \qmlproperty string PackageManager::allowInstallationOfUnsignedPackages
+    \qmlproperty bool PackageManager::allowInstallationOfUnsignedPackages
     \readonly
 
     This readonly property reflects the \l{allow-unsigned-packages}{\c allowUnsignedPackages}
diff --git a/src/manager-lib/packagemanager.h b/src/manager-lib/packagemanager.h
index 82f619e0..ee8525d9 100644
--- a/src/manager-lib/packagemanager.h
+++ b/src/manager-lib/packagemanager.h
@@ -49,6 +49,7 @@ class PackageManager : public QAbstractListModel
     Q_CLASSINFO("D-Bus Interface", "io.qt.PackageManager")
     Q_PROPERTY(int count READ count NOTIFY countChanged FINAL)
     // these are const on purpose - these should never change in a running system
+    Q_PROPERTY(bool installationEnabled READ installationEnabled CONSTANT FINAL REVISION(6, 10))
     Q_PROPERTY(bool allowInstallationOfUnsignedPackages READ allowInstallationOfUnsignedPackages CONSTANT FINAL)
     Q_PROPERTY(bool developmentMode READ developmentMode CONSTANT FINAL)
     Q_PROPERTY(QString hardwareId READ hardwareId CONSTANT FINAL)
@@ -94,6 +95,7 @@ public:
 
     bool isReady() const;
 
+    bool installationEnabled() const;
     bool developmentMode() const;
     void setDevelopmentMode(bool enable);
     bool allowInstallationOfUnsignedPackages() const;