| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
Coverity-Id: 486699
Coverity-Id: 486697
Coverity-Id: 486715
Change-Id: Icdd15ff578f8be55fe9db3ffc38e893f667edc40
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
| |
The propertyList is an array allocated on the JavaScript stack. None of
it can be null.
Coverity-Id: 486709
Change-Id: I3178181aa89bfff86fb5aa469660a912b4f1691c
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The method is (going to be) removed in 6.11 and is currently producing a
compilation error, as the method is marked `override` but is not
overrinding anything anymore, on current development builds that use a
recent qtbase.
Follow along the base class path and the resolution method in similar
patches (e.g for Qt Creator) by removing the method in its entirety.
Change-Id: I6a334681764d9589317ef2121691f8d4e7888b98
Reviewed-by: Ulf Hermann <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
tst_QQuickPopup::closePolicy and cursorShape are no longer flaky on
openSuSE 15.6.
Unblacklist both tests.
Fixes: QTBUG-94251
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: Ic27016893b91fb38c8869c4e357be7b1b88dc45a
Reviewed-by: Axel Spoerl <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
QQuadpath did not maintain the isSubpathEnd-flag, so it would
typically be lost during path processing. Fix to ensure that
algorithms that test for it work correctly.
Pick-to: 6.10
Change-Id: I793b06ef87087cce4a4545bcd7fd2e20ca3790ad
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
The svgtoqml tool has been updated, so we need to update its
generated files as well.
Pick-to: 6.10
Change-Id: Ie58653c35e99e0c1119a9bf64d803371d31261e5
Reviewed-by: Eirik Aavitsland <[email protected]>
Reviewed-by: Hatem ElKharashy <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both QQmlComponent's constructor (the "compile" phase) and create()
(the "create" phase) can produce errors, according to
https://doc.qt.io/qt-6/qqmlcomponent.html#errors.
This fixes a crash caused by an error in the QML, which the tool would
then silently ignore and try to access nullptr items.
Pick-to: 6.5 6.8 6.9 6.10
Change-Id: I2ba6301f8f1f5cd4d804eba290606cf48b584ddb
Reviewed-by: Eirik Aavitsland <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QQmlComponent has two stages where it can produce errors that weren't
accounted for in the first example (which is what most users will see
first): in its constructor and in create(). Add error handling for
these so that users aren't confused when their QML silently fails to
load or they get crashes trying to access non-existent objects returned
by create().
Pick-to: 6.5 6.8 6.9 6.10
Change-Id: I42d0222a997b3cac01cd191bb076513642f5716d
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added braces to the m_hasQueuedStatus check for consistency
and to prevent potential errors if more statements are added later.
No functional changes.
Amends 76bb559e5fbf2dfaf017f8b4a3435938b4d5f4fa
Pick-to: 6.10 6.9 6.9.2
Change-Id: Ic465f41cf08aed0f3f6222786f8fa13f8657d385
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These binding loops were introduced in
0e4d470d3df3963db3546f94e580994473052283, since the nested
overwriteConfirmationDialog's width were still determined by the contentItem,
but the contentItem's width depended on the overwriteConfirmationDialog's
width.
This resulted in a binding loop, which could be fixed by giving the
overwriteConfirmationDialog an explicit width.
Pick-to: 6.10
Change-Id: I3bb2957fd31710b093eb7f7e887df8f045809921
Reviewed-by: Mitch Curtis <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SideBar were facing two major issues.
The first had to do with the buttonDelegate's `required icon` line,
which didn't work after 7322e051c9c3d8dc715c20a3d42d9be83ea2295c,
resulting in an error during component creation.
The other issue had to do with the icons qrc paths only working for the
Basic style. Since the paths were relative, they'd assume that no file
selectors were being used, and thus a simpler path resolution.
This caused all non-basic styles to resolve the url to an invalid
resource.
The first issue was fixed by removing `required icon`, and the latter
was fixed by using complete qrc paths.
In addition, we do a small drive-by fix, by putting a user facing string
into qsTr().
Pick-to: 6.10 6.9
Change-Id: If6cd7ab638ec349b39fe0e4bc763ead78a51a0f4
Reviewed-by: Jonas Karlsson <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
As highlightedIndex property is added to SearchField, relevant style
implementations that previously relied on currentIndex have been updated
to use highlightedIndex.
Pick-to: 6.10
Change-Id: Ib8bc065c92aa95a1ea5ea3cd5c3825bbd15c2f2d
Reviewed-by: Jan Arve Sæther <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QJSValue is slow and can be avoided. Use more specific types.
Also, switch to an exception based error handling instead of
returning undefined.
Amends 5e312953f6c41f244344bbd05a41f205a8d3f86d, found in API review
Pick-to: 6.10
Change-Id: Ie7c304a0dd76c8096e7c1f9b7cc3cfe7471649da
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
The engine handles this just fine, and we had examples (and probably
documentation) shownig this pattern.
If we want to warn about it, it should have a dedicated warning.
Pick-to: 6.10
Change-Id: I105f4a49ecfc6fbd5f00c683e0dbef7d34a64a1d
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want QRangeModel to be the preferred mechanism for exposing C++ data
to QML. Ideally, it will also be a replacement for using QVariantList or
QObjectList, without the "quirks" of exposing a value type holding
references, modelData vs named roles, no write-back etc.
To make sure that the respective usage patterns don't break, add a test
for QVariantList and QObjectList, and corresponding tests that use
QRangeModel with equivalent data structures.
The test shows some unexpected and excessive calls to both data() and
setData() implementations of QRangeModel, which are QEXPECT_FAIL'ed for
now. Unrelated to this test of QRangeModel, so leaving that for a future
commit.
Pick-to: 6.10
Change-Id: I870c78d845de507dafd27f6999154a1a7ea92a1b
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
| |
Change-Id: I0204e4ca1ee787b7f7c8a5f8d980475554a50aac
Reviewed-by: Qt Submodule Update Bot <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already done for FileDialog, but not for FolderDialog.
It prevents a crash.
Amends 87f6e63dfc32e4eac861f3490cb961dfbb028b23
Pick-to: 6.10 6.9 6.8
Change-Id: If6ab9152b9f1f5dcef92dfa891d09202968ef81e
Reviewed-by: Mitch Curtis <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 6.10 Qt i18n component allows mixing id based with text
based translation and this is reflected in lrelease, lupdate,
and documentation.
This patch is a partial revert of
8b61addfa42525c1bd5f27febbe62dcbdb645fc9 and removes the
qmllint warning in the case of mixing these two.
Pick-to: 6.10
Change-Id: Iae2407da2bc5cc21fc3664051834c99b8c72fe58
Reviewed-by: Sami Shalayel <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Use qt_internal_add_RunCMake_test instead of add_RunCMake_test to
ensure Qt specific behaviors are applied.
Pick-to: 6.8 6.9 6.10
Change-Id: Ia751f66cd4cd76e76ea0bb5e31f4b8372b2ca22a
Reviewed-by: Joerg Bornemann <[email protected]>
|
|
|
|
|
|
|
|
| |
Amends e0791e838daeb0dc99a3f28270bbfda3214a9fbf.
Pick-to: 6.8 6.9 6.10
Change-Id: I8bf20c2cb01e1ff8e261fbb0c596a5b6b6c8aa68
Reviewed-by: Nicholas Bennett <[email protected]>
|
|
|
|
|
|
|
|
|
| |
This commit adds some tests for QtQuickView and QtQuickViewContent
signal listeners that are registered before the QML is loaded.
Task-number: QTBUG-137057
Change-Id: Id10420186399cb49d63f281ae195eeacf325250d
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
| |
Update return value and behavior descriptions in
QtQuickView/QtQuickViewContent::connectSignalListener functions.
Change-Id: I566b5c7940c74daec6f20072d2db35bb66d3f86f
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SignalQueue, implemented in an earlier patch, in QtQuickView and
QtQuickViewContent to handle connecting to QML signals before the QML
is done loading, in these cases:
* QtQuickView: If the underlying QAndroidQuickView object has not been
created
* Once the QAndroidQuickView is created and the view reference is
set, we can send the queued connections to the C++ side safely.
* QtQuickViewContent: If the Content has not been attached to a
QtQuickView
* Once the Content has been assigned a QtQuickView, we can send
these queued connections to the QtQuickView safely. The
QtQuickView may or may not queue these as well.
Task-number: QTBUG-137057
Change-Id: Id84fb184d2d60a95f0ffb77896d0c553d7f52338
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class will be used in both QtQuickView and QtQuickViewContent, to
keep track of queued signal connections and eventually process them,
connecting them to the QML view.
This class also introduces an internal class to represent the data
required to make a successful signal connection, to assist with storing
the data.
Task-number: QTBUG-137057
Change-Id: I798dbf0c0b377f2bf07874b17b83d493aa4905d9
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
So that later patches can return valid values from the API when
connecting to signals of QML views that have not been loaded, the Java
API must be able to generate listener IDs. These calls can even happen
before the Qt libraries are loaded.
Task-number: QTBUG-137057
Change-Id: If2cafe8fd65841d2bcfc4a079939d81a279c7982
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds a queue mechanism and API in QAndroidViewSignalManager
that allows callers to add signal listeners before the QML view has
been loaded.
API Added to QAndroidViewSignalManager always returns true, but might
still fail if a signal with the desired signalName does not exist. If
using the QtQuickViewContent API, this should never happen, but with
the QtQuickView API, this is a possibility with typos or signal names
that are computed with some logic in code.
Internally, QAndroidViewSignalManager listens to the
QQuickView::statusChanged signal to detect when the QML view is done
loading.
Task-number: QTBUG-137057
Change-Id: I2ea95f096517f2b7f45a60f236923d42cb5cf1fe
Reviewed-by: Assam Boudjelthia <[email protected]>
|
|
|
|
|
|
|
|
| |
The singleton is in the wrong folder, and is missing a qmldir entry to
be valid.
Change-Id: I7d9d12681d025f6ca257cc1cfbcfb02fc977721d
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using namespaced Qt, we need to prevent symbol clashes with symbols
of the same name.
* namespace some publicly visible classes
* hide classes in implementation in an anonymous namespace
* rename read/write to readValue/writeValue to avoid name clash with c
functions.
Task-number: QTBUG-138543
Pick-to: 6.10
Change-Id: Ica77462c1f81f1e01cc60477e5b56ecfe3c1abb4
Reviewed-by: Ulf Hermann <[email protected]>
|
|
|
|
|
|
|
|
| |
Flagged by qtcreator/clangd
Pick-to: 6.10
Change-Id: I155d56e89d47e7c09cd7d1b5cb6ade13af565671
Reviewed-by: Ulf Hermann <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
e7b90cfc31e9b651fd4895944f84d78aa637f120 changed the default to 1
second, which results in confusing failures where 1 second is not
enough... but it also was (QTBUG-139036). Many animations are 1 second
long, so bump the default timeout to 2 seconds.
Task-number: QTBUG-138662
Change-Id: I9b38e6cdbecda17cc2be65e93be4bdc7b8b0a529
Reviewed-by: Ulf Hermann <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the error message for an invalid import qualifier did not show the qualifier name or explain what was wrong.
This change adds the qualifier name to the message and says it must start with an uppercase letter.
Pick-to: 6.10
Fixes: QTBUG-133313
Change-Id: I0bd4bb143f7b4cdc3b26cae73ab42a4fb05977b1
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
This is the 7th patch in an attempt to make QQmlTreeModel and
QQmlTableModel more similar and eventually merge common parts
in a common abstract class.
Task-number: QTBUG-138703
Pick-to: 6.10
Change-Id: Ie73ae28617efd83d2644c7a745eb7c583c0b68e6
Reviewed-by: Mate Barany <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found in 6.10 QML API review
amend 9601b74dabed53e93a7a5144d4c1fadb7876db18
Task-number: QTBUG-137478
Pick-to: 6.10
Change-Id: I3a26307f304277dfd259da3736d1069a43c0cd03
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found in 6.10 QML API review
amend 9601b74dabed53e93a7a5144d4c1fadb7876db18
Task-number: QTBUG-137478
Pick-to: 6.10
Change-Id: I11fcf5317add4c07e211cff70d3b2e86bd470000
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Determining the fill side of a segment would fail if the path
contained an overlapping segment in the opposite direction. If a
subpath started with such a segment, the resulting fill could be
incorrect. Fix by iterating over the subpath for a segment with a
determinable fill side.
Fixes: QTBUG-133247
Pick-to: 6.10 6.9 6.8
Change-Id: I07c4f884d525b19af93609bcb31b412d340bebd5
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids the need to run qt-cmake-standalone-test and then import
the test, as described in QTCREATORBUG-25389.
Task-number: QTBUG-93020
Pick-to: 6.5 6.8 6.9 6.10
Change-Id: Idafddadfa91f5de9503983a22089fa6d8408ca4d
Reviewed-by: Volker Hilsheimer <[email protected]>
Reviewed-by: Eirik Aavitsland <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Add null check to avoid accessing enginePriv after it is set to nullptr.
Pick-to: 6.10 6.9 6.8 6.5
Fixes: QTBUG-138927
Change-Id: I180828066a100465694337c4378139cfd9e4ab06
Reviewed-by: Axel Spoerl <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The warning was:
QWARN: tst_QQuickMenu::FluentWinUI3::nativeStatic() qt.qpa.menus: QPlatformMenuItem(0x60c0001c5040) does not belong to <QCocoaNSMenu: 0x6070000884a0>
Title:
Supermenu: 0x0 (None), autoenable: YES
Previous menu: 0x0 (None)
Next menu: 0x0 (None)
Items: (
)
In nativeStatic.qml, we have an item tree that looks like this:
Menu {
Action { /* ... */ }
MenuItem {
action: Action { /* ... */ }
}
Menu {
Action { /* ... */ }
}
}
Removing the first two menu items of the top-level menu works. When we
get to the menu item for subMenu, we see that it has a Menu of its own,
and so we call recursivelyDestroyNativeSubMenus. That removes all of
the menu's native items, and at the end it does this:
menuPrivate->resetNativeData();
Here, menuPrivate refers to subMenu's private object. This line severs
the connection between subMenu and menu, which leads to the warning. We
then return from recursivelyDestroyNativeSubMenus and end up here in
QQuickMenuPrivate::removeNativeItem:
if (nativeItem->handle()) {
handle->removeMenuItem(nativeItem->handle());
syncWithNativeMenu();
}
The removeMenuItem call then triggers the warning.
To fix this, we need to have control over when resetNativeData is
called, so that we can do it after the removeMenuItem call. Do so by
rewriting removeNativeItem to be recursive, and using it in favour of
recursivelyDestroyNativeSubMenus, which we then remove.
Improve internal docs while we're at it.
Pick-to: 6.8 6.9 6.10
Change-Id: I4955a5e4d8e5aa5c9d46873b8b3a27f65446ea35
Reviewed-by: Richard Moe Gustavsen <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dialogs uses QFLAGS to bring in various classes via related
meta-objects. The goal is to expose specific enums in the QML API.
What it does instead is to expose all enums of those classes at runtime,
but not to tooling.
Switch the code to use QML_EXTENDED_NAMESPACE, which also exposes all
enums at runtime, but also to tooling.
Task-number: QTBUG-137075
Pick-to: 6.10
Change-Id: Id8d5858575a445f957572fc090df482db1b6fce8
Reviewed-by: Mitch Curtis <[email protected]>
Reviewed-by: Oliver Eftevaag <[email protected]>
|
|
|
|
|
|
|
|
|
| |
It predates the public history, and a look at the private history
confirms that it is no longer relevant.
Change-Id: I08d743a1963ae49fa3f21909725350e05936b725
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Luca Di Sera <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If QT_LINT_EXAMPLES is set, any target defined below the "examples"
folder will add its lint target to the ALL target.
Together with a change in CI to actually pass that define down, we can
enforce absence of qmllint warning by combining it with a .qmllint.ini
file setting max warnings to 0.
Pick-to: 6.10
Task-number: QTBUG-108448
Change-Id: I0f4fd1d18221e503d93e3f435bbc47292857ec20
Reviewed-by: Alexey Edelev <[email protected]>
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
| |
A few enums have been added and uiLanguage got a change signal.
Pick-to: 6.10
Change-Id: I2554c65c9d948881b3694e07df5df8309fc29073
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
| |
std::function is quite heavy-weight.
Coverity-Id: 486648
Change-Id: Ia7c61a726bde9c9d6a02412b9aa5f683bb4d355a
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
|
| |
We can re-use the same code for file and directory imports. And we can
avoid copying a QString this way.
Coverity-Id: 486646
Change-Id: Id95226674e382a722527ba3ff6205682ffe1075a
Reviewed-by: Sami Shalayel <[email protected]>
|
|
|
|
|
|
|
|
|
| |
We have already dereferenced passMan a few lines before and that
obviously succeeded.
Coverity-Id: 486649
Change-Id: I36dcef5757013acf98d665396a3f8f3d289bfee1
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
If we're called directly from a CallPossiblyDirectEval instruction, that
instruction must live in a function which must have created a stack
frame.
Coverity-Id: 486651
Change-Id: I8136f40a8b6058ad499a7fdaaed99bf85485b11c
Reviewed-by: Olivier De Cannière <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Amends 9bc8445766b0a4f8f3126f0a725d58426c2b2d39 that forgot to remove
the .qml file from the test.
Task-number: QTBUG-138896
Change-Id: I85d2d1ce97ef38219e9820aa6308f57bbb40d2c1
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Amends 13761ee3c7d6ecb756db490d8c1fa8980117dca4 that added FileB.qml but
never used it.
Task-number: QTBUG-138896
Change-Id: Id83634bbea3f5fb1184ffe8e4cef9e08c5d8627a
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
Amends ff6d16d58bef108b7bbe35aa8e9d79dd3a2ea872 that added the files but
didn't use them.
Task-number: QTBUG-138896
Pick-to: 6.10 6.9 6.8
Change-Id: I1835e2a8db9e374628da7bb8e16c39d876dc9d91
Reviewed-by: Olivier De Cannière <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the QAccessible::ParentChanged callback.
Probaby not possible with a perfect implementation.
What can reasonably be done is to issue ParentChanged on;
QWidget::setParent, QWindow::setParent, QQuickItem::setParentItem.
However calling these functions do not necessarily map 1:1 to QAccessibleInterface::parent(). One common reason for why the two hierarchies will diverge is because of the Accessible.ignored state
Task-number: QTBUG-134923
Change-Id: Iaa8cfd3d65c0fac137c95434ec21176e7aea6699
Reviewed-by: Jan Arve Sæther <[email protected]>
|