aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Compiler: Enable color output on supported consoles on WindowsHEADdevOlivier De Cannière13 hours1-6/+16
| | | | | | | | | | | | Windows 10 enabled support for ANSI escape sequences. Let's use them. [ChangeLog][QML] Color ouput for qmllint and qmlcachegen is now also enabled on Windows on terminals that support it. Fixes: QTBUG-139228 Change-Id: I5e48e1052823ef4d0e6005482c9a1bee210e0929 Reviewed-by: Zhao Yuhang <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
* Doc: add a Varying Delegate Sizes sectionMitch Curtis23 hours4-0/+14
| | | | | | | | | | | | 2436de31bc48b0576d2f48507a89ffbb719e52c1 added documentation for this to ListView, but we also need it in other places so that users don't miss it. Task-number: QTBUG-139026 Pick-to: 6.8 6.9 6.10 Change-Id: I7274bf4524baee4711f370e012009c97a140fd4e Reviewed-by: Richard Moe Gustavsen <[email protected]> Reviewed-by: Matthias Rauter <[email protected]>
* QML generator: improve detection of constant animationsEirik Aavitsland27 hours1-1/+5
| | | | | | | | | | It can happen that also animations with more than 2 registered frames turn out to have a constant value, and thus can be simplified. Improve the detection function to cover also such cases. Pick-to: 6.10 Change-Id: I7f95e0371be6d36bcebff01a99ffa0cd226b54ef Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
* Update correct version in the quick flexboxlayoutSanthosh Kumar31 hours1-1/+1
| | | | | | Pick-to: 6.10 Change-Id: I5cdc5e2d3976620d3e387905015449adf0703a45 Reviewed-by: Ulf Hermann <[email protected]>
* qmlls: find C++ & QML definitions of enumSami Shalayel31 hours5-4/+103
| | | | | | | | | | | | | Implement go to definition for enums (values and keys) defined from C++ or QML. This allows user to jump to their own C++ files, and does not jump to headers outside the project folder, like private/qquickitem_p.h for example, as it might get confusing for the user to open a file in the editor that they are not supposed to edit. Task-number: QTBUG-128393 Change-Id: I0410ecf4cf810e6c6072038bffc4564eb787c7fc Reviewed-by: Olivier De Cannière <[email protected]>
* qmlls: find C++ definitions of grouped propertiesSami Shalayel31 hours4-1/+54
| | | | | | | | | | | | | | | Implement go to definition for grouped properties. Jump to the C++ file at the correct line when searching for grouped properties from QML. This allows user to jump to their own C++ files, and does not jump to headers outside the project folder, like private/qquickitem_p.h for example, as it might get confusing for the user to open a file in the editor that they are not supposed to edit. Task-number: QTBUG-128393 Change-Id: I190a71b51b618e4050c9542f987d67e9b835a59f Reviewed-by: Olivier De Cannière <[email protected]>
* qmlls: find C++ definitions of attached typesSami Shalayel31 hours6-3/+80
| | | | | | | | | | | | | | | | | | Implement go to definition for attached types defined in C++. Jump to the C++ file at the correct line when searching for attached types or their methods and properties from QML. Support both cases of attached types: Attached types in the binding target property or in the binding itself. This allows user to jump to their own C++ files, and does not jump to headers outside the project folder, like private/qquickitem_p.h for example, as it might get confusing for the user to open a file in the editor that they are not supposed to edit. Task-number: QTBUG-128393 Change-Id: I4c40d7241227d2e5921c85ab7756782a37e5a0ad Reviewed-by: Olivier De Cannière <[email protected]>
* qmlls: find C++ definitions of methodsSami Shalayel31 hours4-0/+21
| | | | | | | | | | | | | | | Implement go to definition for methods (signals, slots, invokables) defined in C++. Jump to the C++ file at the correct line when searching for methods from QML. This allows user to jump to their own C++ files, and does not jump to headers outside the project folder, like private/qquickitem_p.h for example, as it might get confusing for the user to open a file in the editor that they are not supposed to edit. Task-number: QTBUG-128393 Change-Id: I7dcd347dcc925fd8e85cc2188c63cfdeab318a96 Reviewed-by: Olivier De Cannière <[email protected]>
* qmlls: find C++ definitions of propertiesSami Shalayel31 hours4-7/+38
| | | | | | | | | | | | | | | | | Implement go to definition for properties of QML components defined in C++. Jump to the C++ file at the correct line when searching for properties ofQML Component types from QML. This allows user to jump to their own C++ files, and does not jump to headers outside the project folder, like private/qquickitem_p.h for example, as it might get confusing for the user to open a file in the editor that they are not supposed to edit. Also log a warning when a C++ header was not found. Task-number: QTBUG-128393 Change-Id: I9da962b671dfe1f9e29fb260655f4f37132c6815 Reviewed-by: Olivier De Cannière <[email protected]>
* qmlls: cleanup go to cpp componentSami Shalayel31 hours2-43/+34
| | | | | | | | | Avoid triggering a warning, and use the same code paths when going to the definition of singleton and non-singleton types. Task-number: QTBUG-128393 Change-Id: I1376adf0423d239aab1f7cad01a35f2c5db53874 Reviewed-by: Olivier De Cannière <[email protected]>
* tst_qmlls_utils: remove invalid test for attached derived typeSami Shalayel31 hours2-7/+3
| | | | | | | | | | | | | | We want to warn about using attached derived types in QTBUG-138873, so remove the test that was testing whether go to definition jumps to the derived type MyApplicationWindow when querying for the MyApplicationWindow.footer attached property of the ApplicationWindow base type. A later commit will make qmlls jump to the C++ definition of the attached type, instead of the QML type. Task-number: QTBUG-128393 Change-Id: Ieb96e94315fe8f053302aee3f44cd2437c81fbe0 Reviewed-by: Fabian Kosmale <[email protected]>
* qmllsutils: distinguish attached types in bindingsSami Shalayel31 hours5-2/+9
| | | | | | | | | | | | | Attached types on the left hand side of a binding have a different scopes than attached types on the right hand side of a binding. Special case them in resolveExpressionType to allow to implement go-to-definition on attached types correctly for both kind of scopes in a later commit. Task-number: QTBUG-128393 Change-Id: Id82f3572014c8c8310cc359c4ed0bbfb6465cf7c Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Olivier De Cannière <[email protected]>
* qmltyperegistrar: add line numbers to methods, properties and signalsSami Shalayel31 hours9-27/+148
| | | | | | | | | | Add line numbers to qmltyperegistrar's output now that MOC includes this information in its output. Task-number: QTBUG-119143 Task-number: QTBUG-128393 Change-Id: Id77ef37f1503bd17fa42a355770a1ffeb348b46e Reviewed-by: Fabian Kosmale <[email protected]>
* tst_qmlformat_cli: make sure qmlformat settings stay stableSami Shalayel36 hours1-0/+15
| | | | | | | | Add a test to make sure that the keys stay stable, and don't get changed in the future. Change-Id: If5a4c06d4f821fd4f6269e61bbb89bd120e79243 Reviewed-by: Semih Yavuz <[email protected]>
* tst_qmlformat_cli: also test default values for semicolonruleSami Shalayel36 hours1-0/+3
| | | | | | | Add a test for the default value of the semicolon rule. Change-Id: Id2e52bbc277707ef042675a4f91254a072a98c37 Reviewed-by: Semih Yavuz <[email protected]>
* QQmlToolingSettings: Pass large objects as const refUlf Hermann36 hours2-11/+14
| | | | | | | | | | Coverity wants us to move them instead but moving out of locals makes it easy to accidentally move out of a local you still need. We prefer to use const refs, except in hot code paths. Coverity-Id: 487583 Change-Id: I9dca9122d7fb8797b3d45e197be747fd16d16165 Reviewed-by: Sami Shalayel <[email protected]>
* Make sure to setup viewport and scissors also for RenderNodesDominik Holland41 hours4-5/+40
| | | | | | Pick-to: 6.8 6.9 6.10 Change-Id: Ie3da3ba0aab73ad61fa32593bcdd19ffcc714a02 Reviewed-by: Laszlo Agocs <[email protected]>
* qqml: Remove unused MatchScore::VariantMatchOlivier De Cannière42 hours1-1/+1
| | | | | | | Amends 12fb7d27431a7db2a19e1954c85d5dc03264b356 Change-Id: I3af53164851a30317a1fdb5b9190bf7473c3d1ea Reviewed-by: Ulf Hermann <[email protected]>
* Compiler: Detect calls on partially deleted objects and throwOlivier De Cannière42 hours4-6/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Component.onDestruction can be used to execute some code as an object is being destructed. The code may, however, reference objects that are no longer in a valid state because they themselves have already been destructed. We then throw an exeception. Commit a741271dd58b21728928684f1ef1efaa91e79ebf introduced the init step for calls in which the types of arguments are resolved. For object methods, we need to check that the object is still valid or throw an exception otherwise. This is made more complicated by the fact that, in some cases, the destruction of the object happens in a somewhat chaotic manner where, for instance, the object is still alive but its method and property storage has already been deleted. This inconsistent state is the cause of QTBUG-138516 and existing checks for invalid objects were not sufficient and we crashed when trying to use the function that we were unable to resolve. We can detect this particular problem by checking whether the ddata of the object still has its jsWrapper. Amends a741271dd58b21728928684f1ef1efaa91e79ebf Fixes: QTBUG-138516 Pick-to: 6.10 6.9 Change-Id: Ifdd7708d73ea6012d1e07aebed257b3f538183c1 Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Fabian Kosmale <[email protected]>
* SearchField: Fix baseline test failuresDilek Akcay42 hours3-89/+58
| | | | | | | Fixes: QTBUG-139093 Pick-to: 6.10 Change-Id: I48fb06082ea7bf10795b715e3e42862a83df6c31 Reviewed-by: Mitch Curtis <[email protected]>
* Doc: Demonstrate finding some private modulesSze Howe Koh4 days2-0/+3
| | | | | | | | | | | | | | Explicitly finding a private module was not strictly required in Qt 6.9 and older. This patch adds a small demonstration to some snippets, to show how to find QmlPrivate/QuickPrivate. This might be helpful for users who're scratching their heads when their previously-working project now fails to build in Qt 6.10. Change-Id: Ia8a08d94ea65aa73a44c7a7610d28119582ebf0f Pick-to: 6.10 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Alexandru Croitor <[email protected]>
* QtQml: Add method to generate a QVariantHash from a JS objectUlf Hermann4 days2-7/+20
| | | | | | | | | | This generalizes the QVariantMap code path. Pick-to: 6.10 6.9 6.8 Task-number: QTBUG-139025 Change-Id: Ibbdc1da974d3c166474c4bd02fb4c70d8df3e688 Reviewed-by: Semih Yavuz <[email protected]> Reviewed-by: Fabian Kosmale <[email protected]>
* QtQml: Fix formattingUlf Hermann4 days3-370/+364
| | | | | | | | ReferenceObject and VariantAssociationObject were indented in rather confusing ways. Change-Id: I3a4ef04f716609a0b32844bb14e4dfded6a1f2fa Reviewed-by: Semih Yavuz <[email protected]>
* FileDialog: remove 'required icon' from SideBar's addFavoriteDelegateOliver Eftevaag4 days4-4/+0
| | | | | | | | It was causing the button to never appear when it should. Pick-to: 6.10 6.9 Change-Id: I59d13d0e2588536c384fd2c6024dd9f5d7a24274 Reviewed-by: Mitch Curtis <[email protected]>
* FileDialog: Use SplitView to separate the sidebar from the contentOliver Eftevaag4 days14-54/+193
| | | | | | | | | | | | | | | | | | | | | | Previously a RowLayout was being used. But I would argue that it's better UI to use a SplitView instead. Add the necessary overrides in QQuickSideBar, so that the SideBar actually knows it's correct implicit size. This is needed in order for the SplitView to work correctly. We want the implicit width to be large enough to cover the delegate with the most text, with a maximum width of half the available space in the dialog. As for the height, we want it to be tall enough to cover all the standard paths + add favorite button, so that the feature of adding directories to the favorite list is less cumbersome. The height of the sidebar should be part of what determines the implicit height of the dialog. Pick-to: 6.10 Change-Id: If267d8197e82f8a91a059e31723c46fe95af3d41 Reviewed-by: Mitch Curtis <[email protected]>
* QtQmlModels: Fix QML names and revisionsUlf Hermann4 days10-5/+13
| | | | | | | | | | | | Names of QML components should not start with 'Q' and new components should have a QML_ADDED_IN_VERSION. Amends commit 9efc1fb4ac7982f105a13781fccff74a61907601. Pick-to: 6.10 Change-Id: I1044603f7afab3fee92cd84b1a2a84f0564e6a73 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Santhosh Kumar <[email protected]>
* QQmlValueTypeWrapper: fix stack-use-after-return and missing destructorAurélien Brooke4 days1-5/+7
| | | | | | | | | | | | | | | If isReference() is true and we allocate a gadgetPtr() on the stack with alloca(), then when readReferenceValue() fails, we return immediately, leaving a bad pointer in d()->gadgetPtr(): - gadgetPtr now references alloca() memory from a function that returned - the destructor of the gadget is never called To fix this, ensure that we destruct and nullptr the gadget on all exit paths, thanks to a qScopeGuard(). Pick-to: 6.10 6.9 6.8 6.5 Change-Id: I4ff411c0f364ad337fdbd55772812e1f219e6dff Reviewed-by: Ulf Hermann <[email protected]>
* doc: Add a note about escaping characters with qt_target_qml_from_svgEskil Abrahamsen Blomfeldt5 days1-1/+4
| | | | | | | | Cmake escapes some characters but not all, so you may end up with invalid command lines on some platforms. Change-Id: I1a3aad0b3d48b9e2dea2c4b1b55e371f286dfd46 Reviewed-by: Alexandru Croitor <[email protected]>
* Rename flexboxlayout example directory in consistent with othersSanthosh Kumar5 days3-0/+0
| | | | | | Pick-to: 6.10 Change-Id: Ie189960af25a33f0dee54fbd49213f9d5eab5891 Reviewed-by: Mitch Curtis <[email protected]>
* qmlformat: allow specifying an alternative location for settingsSemih Yavuz5 days6-8/+84
| | | | | | | | | | | | When requested, use the specified .qmlformat.ini file as the setttings file. When --settings option is given through commandline, do not perform per-directory configuration lookup. Adapt the test to accept the SearchOptions. Fixes: QTBUG-107212 Change-Id: I6b4f2c4a4321f89ae6dabf89a866c53486c22cce Reviewed-by: Sami Shalayel <[email protected]>
* qmltoolings add --dry-run option for qmlformat and qmllintSemih Yavuz5 days12-14/+146
| | | | | | | | | | | | | Add reportConfigForFiles to generic tooling class. It will perform the search for the given files. Use stdout to report. qmllint had already an option --dry-run for printing the fixed codes, but we can still allow this to use that option name. For qmlls, report the path if verbose option is set. Fixes: QTBUG-137874 Change-Id: I6bd43866073b3df832b6fd89d477bced869d74c0 Reviewed-by: Ulf Hermann <[email protected]>
* SearchField: Add Windows styleDilek Akçay Öztüzün5 days11-1/+194
| | | | | | | Task-number: QTBUG-137318 Pick-to: 6.10 Change-Id: I3e4d506ce6b8961b85bfb8a992c6de345ea7c1f1 Reviewed-by: Jan Arve Sæther <[email protected]>
* Material Style: fix focusIn and focusOut animation issuesMorteza Jamshidi6 days5-104/+148
| | | | | | | | | | | | When a property potentially used in focusIn or focusOut animation is changed, we need to reschedule the animation with the correct parameters. properties like verticalPadding, leftPadding, controlHasText, ... To fix the issue I simplified focus animation logic. Fixes: QTBUG-138028 Change-Id: I115fb6fdd5676ae0282b5b4b5bd460ea3b28392a Pick-to: 6.10 6.9 6.8 Reviewed-by: Mitch Curtis <[email protected]>
* QSGThreadedRenderLoop: Handle window hiding at polish stepVlad Zahorodnii6 days3-1/+79
| | | | | | | | | | | | | | | | | | | | | A window can be hidden during the polish step. For example, an app may hide its window if the geometry is not good enough. This can result in the following render thread events if the QPA sends sync expose events: - WM_Obscure - WM_TryRelease - WM_RequestSync The WM_RequestSync event comes from the WMSyncEvent. With QtWayland, repainting a window after it has gotten unexposed can lead to the compositor posting a protocol error. There is also matter of keeping code predictable: if the QPA sends an unexpose event, it'd be great if the app stops repainting. Pick-to: 6.10 Change-Id: I1d477436d6f79156aca44960c47a84f2e12ca4d2 Reviewed-by: Andy Nichols <[email protected]>
* QML generator: lighten produced qml by skipping constant animationsEirik Aavitsland6 days2-15/+59
| | | | | | | | | | | | | | | | | | In animated transforms, it is common that only 1-2 of the properties (scale/translate/rotate/anchor) are actually animated, while the rest have constant, and often default, values. To lighten the generated qml code somewhat, this patch skips generating Animation items for constant value properties. In particular, it skips animating the center/origin point of rotations when not needed. And for properties with constant default values, the entire Transform object is skipped. Depending on the inpu, this saves 10-50% of the size of the generated qml, and correspondingly saves loading time and processing load. Fixes: QTBUG-139076 Pick-to: 6.10 Change-Id: I151164b63356b0fd3b15cfcdc8d163f835d46fde Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
* tst_qmlformat_cli: remove hand-written keysSami Shalayel6 days1-21/+32
| | | | | | | | | | Remove the hand-written keys from the test and use the static strings instead. One of the previous hand-written key had a typo. Also make sure that the settings are really set, as QVariant::toBool() returns false for a unset settings, for example in the case of the key with the typo. Change-Id: I15da10409fbf374a475dc3930844fd56120f370a Reviewed-by: Semih Yavuz <[email protected]>
* qt_target_qml_from_svg() command in cmakeEskil Abrahamsen Blomfeldt6 days5-0/+163
| | | | | | | | | | | | | This adds a build command for generating QML files out of SVG files automatically. It works by first calling svgtoqml on the sources and then adding these to the QML module for the target. [ChangeLog][svgtoqml] Added a cmake api for automatically generating QML files from SVG files in an application. Task-number: QTBUG-128915 Change-Id: I44e70f0ada4ca8ac9ac8253d46832d3a286da927 Reviewed-by: Alexandru Croitor <[email protected]>
* Dialogs: only return valid QPlatformDialogHelper if Qt Quick dialog isMitch Curtis6 days1-5/+15
| | | | | | | | | | | | If we don't do this, QQuickAbstractDialog::create will see that m_handle is valid and call onCreate, which tries to call selectedFiles and we get a crash. Amends f9421abbdf4d2e2be06febf9f75a2b62e6875835. Pick-to: 6.5 6.8 6.9 6.10 Change-Id: Id522e068c689a5bc5662466e446f99586bc7c738 Reviewed-by: Oliver Eftevaag <[email protected]>
* wasm: a11y - Send ObjectDestroyed event from quickitem destructorEven Oscar Andersen6 days4-4/+30
| | | | | | | | Also, turn QQuickAccessible items to invalid() once the QuickItem destructor starts. Change-Id: I8b6bc7d69ffaeb01eb453e75de2847efb869cbf2 Reviewed-by: Jan Arve Sæther <[email protected]>
* Qml[Table|Tree]Model: Move data to QAbstractColumnModelMatthias Rauter6 days6-109/+72
| | | | | | | | | | | | The only difference in the function is moved into dataPrivate. This is the 9th patch in an attempt to make them more similar and eventually merge common pars in a common abstract class. Task-number: QTBUG-138703 Pick-to: 6.10 Change-Id: I6b247121f64b070ee31846a5da4be9ad1abb93be Reviewed-by: Mitch Curtis <[email protected]>
* Qml[Table|Tree]Model: Move setData to QAbstractColumnModelMatthias Rauter6 days6-154/+94
| | | | | | | | | | | | | | The only difference in the function is moved into setDataPrivate. Q_STATIC_LOGGING_CATEGORY lcTreeModel is no longer used. This is the 8th patch in an attempt to make them more similar and eventually merge common pars in a common abstract class. Task-number: QTBUG-138703 Pick-to: 6.10 Change-Id: Id7a7166a7dd31a5ab3908e68571bc802729798a3 Reviewed-by: Mitch Curtis <[email protected]>
* DeliveryAgent: stop sending hovering mouse moves to grabberShawn Rutledge6 days6-12/+97
| | | | | | | | | | | | | | | | | | | | For applications running under Qt Wayland compositors, touch events may be accompanied by fake mouse moves coming from the touchscreen device. That might or might not be useful: but since most of Qt Quick ignores such stray mouse moves, and PinchHandler was getting deactivated by them, we now make an effort to avoid delivering them to PinchHandler after it has become the exclusive grabber of those touchpoints (which looks the same as being the grabber of "that" mouse). Added a reminder to the handlePointerEvent() comment that tablet events are different: hover events are not enough, in fact we need to deliver TabletMove events to HoverHandler so that it has a chance to change the cursor (i.e. keep the tst_HoverHandler::deviceCursor test working). Pick-to: 6.8 6.9 6.10 Fixes: QTBUG-123985 Change-Id: I513caf277e2fb87401b3e0bb5547f9623467b423 Reviewed-by: Richard Moe Gustavsen <[email protected]>
* sg: optimize Renderer::cleanupBatches() by removing sorting and copyingAurélien Brooke6 days1-9/+12
| | | | | | | | | | | | | Replace the previous stable sort + filter approach with an in-place compaction loop that moves valid batches forward and recycles invalid ones immediately. This removes the need for temporary heap storage and avoids redundant copying and sorting, while preserving the original order of valid batches. Change-Id: Icbe2c3d96b5d38a0a1f2c14ce175eb19d45d5a63 Reviewed-by: Andy Nichols <[email protected]>
* Fix QSGGeometryData::hasDirtyIndexData used wrong dirty flagDheerendra Purohit7 days1-1/+1
| | | | | | | | | | | The method incorrectly returned m_dirty_vertex_data instead of m_dirty_index_data. Pick-to: 6.10 6.9 6.8 6.7 6.6 Fixes: QTBUG-123988 Change-Id: Ib99175adabc711c8449ff3db755fbade968f7c63 Reviewed-by: Edward Welbourne <[email protected]> Reviewed-by: Andy Nichols <[email protected]>
* Skip reordering content model if items aren't reparented to item viewSanthosh Kumar7 days3-9/+118
| | | | | | | | | | | | | | | | | | | | | | | The container reorders the content model items after component completion. The content model can be assigned as a model to the item views to visualise through a container content item. The content item can have item views anywhere in the object hierarchy. If the item views are somewhere down in the line and not at the top, there is a chance during component completion that some of the items are reparented to the item views, and others are with the container content item itself. Thus, reordering at this stage (having partial items) can lead to changing the order of elements within the content model, which further causes repositioning of items within the item views. This patch resolves this issue by skipping reordering the content model, if any of the items are not reparented to the item views. Fixes: QTBUG-138490 Pick-to: 6.10 6.9 6.8 6.5 Change-Id: I1673e600774e2821653542c003d2d573f62d024d Reviewed-by: Oliver Eftevaag <[email protected]> Reviewed-by: Mitch Curtis <[email protected]>
* manual tests: compile fix for namespaced qtTim Blechmann7 days2-0/+4
| | | | | | | | QT_USE_NAMESPACE was missing, so they didn't compile with namespaced qt. Pick-to: 6.10 Change-Id: Ic4b1126cfab7780c714a737e81f0947664bade02 Reviewed-by: Ulf Hermann <[email protected]>
* Fix runtime error in the flexboxlayout exampleSanthosh Kumar7 days1-1/+1
| | | | | | | | | | The Text::wrapMode has been referenced incorrectly as Text::wrap and its corrected in this patch. Fixes: QTBUG-137733 Pick-to: 6.10 Change-Id: Ieb1ab02e19bc929f103443f0845a8980daceb245 Reviewed-by: Jan Arve Sæther <[email protected]>
* QtQml: Properly null-check module exports when iteratingUlf Hermann8 days1-2/+2
| | | | | | | | | | | | | We construct the iterator from the exports of the module in all current code paths. Therefore, this case can't happen in the current code. Still, the fact that we have a branch that throws a reference error there tells us that it's intended to work on other collections of names, too. Let's complete the check and also check for nullptr since resolveExport can indeed return that. Coverity-Id: 486706 Change-Id: Ieaf3996e76265e9e6ef59c2168699e47e41e8ff5 Reviewed-by: Olivier De Cannière <[email protected]>
* JSRuntime: Add const correctnessOlivier De Cannière8 days2-5/+5
| | | | | | Change-Id: I2fc82de562909ab2e0eecfbbe1e2e53953a33756 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Ulf Hermann <[email protected]>
* QtQml: Optimize retrieval of string from ValueUlf Hermann8 days1-2/+2
| | | | | | | | stringValue() already checks isString(). We don't have to do it twice. Coverity-Id: 486710 Change-Id: I074228f9a120c3bbfe6d4a65f05fe11322fbd07b Reviewed-by: Olivier De Cannière <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-20 00:53:58 +0000