diff options
| author | Michal Klocek <[email protected]> | 2024-07-29 13:47:55 +0200 |
|---|---|---|
| committer | Michal Klocek <[email protected]> | 2024-08-28 15:14:20 +0200 |
| commit | 746cdfc088eaf4171d8dc1dc0ae489cdd846c68a (patch) | |
| tree | 73e1915be9af09f2f73342c63c7937e3ee1000b6 /src/webenginequick/api/qquickwebengineview.cpp | |
| parent | 46d1e664f2d100355dfcf2438d775189c4d8c0f7 (diff) | |
Fix not working popup with qquick on eglfs
After refactoring in 5d1ef38 we lost popups with qquick.
Unfortunately we do not have tests for it as we do
not run eglfs on ci.
Pick-to: 6.8 6.7
Fixes: QTBUG-119908
Change-Id: Iea6cadf96dcac488898bb31132938fe8020d4d79
Reviewed-by: Allan Sandfeld Jensen <[email protected]>
Diffstat (limited to 'src/webenginequick/api/qquickwebengineview.cpp')
| -rw-r--r-- | src/webenginequick/api/qquickwebengineview.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/webenginequick/api/qquickwebengineview.cpp b/src/webenginequick/api/qquickwebengineview.cpp index 00ec94859..0d3aab27b 100644 --- a/src/webenginequick/api/qquickwebengineview.cpp +++ b/src/webenginequick/api/qquickwebengineview.cpp @@ -261,8 +261,9 @@ public: void InitAsPopup(const QRect &screenRect) override { - Q_UNUSED(screenRect); - Q_UNREACHABLE(); + // note this is called when there is no windowing system + // otherwsie see RenderWidgetHostViewQtDelegateQuickWindow + m_contentItem->setPosition(screenRect.topLeft()); } void Bind(WebContentsAdapterClient *client) override |