summaryrefslogtreecommitdiffstats
path: root/src/plugins/android/qandroidwebview.cpp
diff options
context:
space:
mode:
authorMichal Klocek <[email protected]>2024-11-04 15:28:02 +0100
committerMichal Klocek <[email protected]>2024-11-07 18:53:53 +0000
commitd9d44f99fdb5a5f8206deb2ff460519328d674d8 (patch)
tree42c01332c905fcbb406ffed25f3bdbde2a08a738 /src/plugins/android/qandroidwebview.cpp
parent35630578ba823691268f8e6ffacc4b6c64eded59 (diff)
Fix all tests on android instead of blacklisting them
Fix handling of loadingChanged as this should come from WebViewClient observer. This fixes flaky tests, as they assumed 2 signals coming, but in reality 3 were emitted. In case 3rd did not come in time test would pass. Adjust the title test to match how it works on android. Fix load result logic, as error assumes no load success signal emitted and has to be one of * LoadStartedStatus, * LoadStoppedStatus, * LoadSucceededStatus, * LoadFailedStatus Fixes: QTBUG-102712 Fixes: QTBUG-108752 Pick-to: 6.8 Change-Id: Ie3c729fa854ad1e6270a8276c1f2428af6c2614e Reviewed-by: Christian Strømme <[email protected]>
Diffstat (limited to 'src/plugins/android/qandroidwebview.cpp')
-rw-r--r--src/plugins/android/qandroidwebview.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/android/qandroidwebview.cpp b/src/plugins/android/qandroidwebview.cpp
index 230b913..e4a9bf9 100644
--- a/src/plugins/android/qandroidwebview.cpp
+++ b/src/plugins/android/qandroidwebview.cpp
@@ -411,7 +411,6 @@ static void c_onReceivedTitle(JNIEnv *env,
QAndroidWebViewPrivate *wc = reinterpret_cast<QAndroidWebViewPrivate *>(id);
if (!g_webViews->contains(wc))
return;
-
const QString &qTitle = QJniObject(title).toString();
Q_EMIT wc->titleChanged(qTitle);
}