Skip to content

fix(@angular/ssr): SSR should work without @angular/router #30319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 15, 2025

This fixes SSR to ensure serialization is not broken when router is not provided.

This fixes SSR to ensure serialization is not broken when router is not
provided.
@atscott atscott force-pushed the minimalNoRouterFix branch from 27bd38d to 811194f Compare May 15, 2025 17:31
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels May 15, 2025
@clydin clydin merged commit dfe68c7 into angular:main May 15, 2025
32 checks passed
@clydin
Copy link
Member

clydin commented May 15, 2025

The changes were merged into the following branches: main, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants