Skip to content

fix(@angular/build): enable unit-test builder watch outside CI #30323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented May 15, 2025

When using the experimental unit-test builder, the watch option will now default to true when there is an interactive terminal and not on CI. This more closely aligns with the behavior of the existing karma builder and that of vitest itself. CI is determined by the presence of a "truthy" CI environment variable.

When using the experimental `unit-test` builder, the `watch` option will
now default to true when there is an interactive terminal and not on CI.
This more closely aligns with the behavior of the existing `karma` builder
and that of vitest itself. CI is determined by the presence of a truthy
`CI` environment variable.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 15, 2025
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label May 16, 2025
@clydin clydin merged commit 4da02ca into angular:main May 16, 2025
33 checks passed
@clydin
Copy link
Member Author

clydin commented May 16, 2025

The changes were merged into the following branches: main, 20.0.x

@clydin clydin deleted the unit-test/auto-watch-tty branch May 16, 2025 02:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants